Bug 194741 - [JSC] Remove unused global private variables
Summary: [JSC] Remove unused global private variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-15 21:58 PST by Yusuke Suzuki
Modified: 2019-02-15 23:51 PST (History)
8 users (show)

See Also:


Attachments
Patch (8.87 KB, patch)
2019-02-15 21:59 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (8.87 KB, patch)
2019-02-15 22:02 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-15 21:58:15 PST
[JSC] Remove unused global private variables
Comment 1 Yusuke Suzuki 2019-02-15 21:59:11 PST
Created attachment 362209 [details]
Patch
Comment 2 Yusuke Suzuki 2019-02-15 22:02:04 PST
Comment on attachment 362209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362209&action=review

> Source/JavaScriptCore/builtins/ObjectConstructor.js:33
> +    var names = @Object.@getOwnPropertyNames(object);

Oops, fixed.
Comment 3 Yusuke Suzuki 2019-02-15 22:02:37 PST
Created attachment 362210 [details]
Patch
Comment 4 Joseph Pecoraro 2019-02-15 22:43:41 PST
Comment on attachment 362210 [details]
Patch

Nice!! r=me
Comment 5 Yusuke Suzuki 2019-02-15 23:16:14 PST
Comment on attachment 362210 [details]
Patch

Thank you!
Comment 6 WebKit Commit Bot 2019-02-15 23:41:25 PST
Comment on attachment 362210 [details]
Patch

Clearing flags on attachment: 362210

Committed r241644: <https://trac.webkit.org/changeset/241644>
Comment 7 WebKit Commit Bot 2019-02-15 23:41:27 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-15 23:51:06 PST
<rdar://problem/48135784>