WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194739
[LFC] Apply min/max width constraints to preferred width computation
https://bugs.webkit.org/show_bug.cgi?id=194739
Summary
[LFC] Apply min/max width constraints to preferred width computation
zalan
Reported
2019-02-15 21:14:39 PST
ssia
Attachments
Patch
(8.51 KB, patch)
2019-02-15 21:23 PST
,
zalan
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2019-02-15 21:23:27 PST
Created
attachment 362206
[details]
Patch
Simon Fraser (smfr)
Comment 2
2019-02-15 22:03:14 PST
Comment on
attachment 362206
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=362206&action=review
> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:309 > + auto& formattingState = layoutState.formattingStateForBox(child);
Could that be const auto&?
> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:315 > + auto marginBorderAndPadding = fixedValue(childStyle.marginStart()).valueOr(0)
Extra space
zalan
Comment 3
2019-02-16 04:54:07 PST
Committed
r241646
: <
https://trac.webkit.org/changeset/241646
>
Radar WebKit Bug Importer
Comment 4
2019-02-16 04:55:30 PST
<
rdar://problem/48137982
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug