Bug 194739 - [LFC] Apply min/max width constraints to preferred width computation
Summary: [LFC] Apply min/max width constraints to preferred width computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-15 21:14 PST by zalan
Modified: 2019-02-16 04:55 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.51 KB, patch)
2019-02-15 21:23 PST, zalan
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-15 21:14:39 PST
ssia
Comment 1 zalan 2019-02-15 21:23:27 PST
Created attachment 362206 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-02-15 22:03:14 PST
Comment on attachment 362206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362206&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:309
> +            auto& formattingState = layoutState.formattingStateForBox(child);

Could that be const auto&?

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:315
> +            auto marginBorderAndPadding =  fixedValue(childStyle.marginStart()).valueOr(0)

Extra space
Comment 3 zalan 2019-02-16 04:54:07 PST
Committed r241646: <https://trac.webkit.org/changeset/241646>
Comment 4 Radar WebKit Bug Importer 2019-02-16 04:55:30 PST
<rdar://problem/48137982>