RESOLVED FIXED 194735
[JSC] Lazily create empty RegExp 
https://bugs.webkit.org/show_bug.cgi?id=194735
Summary [JSC] Lazily create empty RegExp
Yusuke Suzuki
Reported 2019-02-15 19:13:13 PST
[JSC] Lazily create empty RegExp
Attachments
Patch (7.12 KB, patch)
2019-02-15 19:14 PST, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-15 19:14:41 PST
Created attachment 362199 [details] Patch
Keith Miller
Comment 2 2019-02-15 19:53:40 PST
Comment on attachment 362199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362199&action=review > Source/JavaScriptCore/runtime/RegExpCache.h:51 > + if (m_emptyRegExp) Should we mark this likely?
Yusuke Suzuki
Comment 3 2019-02-15 20:26:31 PST
Comment on attachment 362199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362199&action=review Thank you! >> Source/JavaScriptCore/runtime/RegExpCache.h:51 >> + if (m_emptyRegExp) > > Should we mark this likely? Sounds nice! Yeah, we should put LIKELY, fixed.
Yusuke Suzuki
Comment 4 2019-02-15 20:32:47 PST
Committed r241640: <https://trac.webkit.org/changeset/241640>
Radar WebKit Bug Importer
Comment 5 2019-02-15 20:33:24 PST
<rdar://problem/48133654>
Note You need to log in before you can comment on or make changes to this bug.