Bug 194735 - [JSC] Lazily create empty RegExp
Summary: [JSC] Lazily create empty RegExp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-15 19:13 PST by Yusuke Suzuki
Modified: 2019-02-15 20:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.12 KB, patch)
2019-02-15 19:14 PST, Yusuke Suzuki
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-15 19:13:13 PST
[JSC] Lazily create empty RegExp
Comment 1 Yusuke Suzuki 2019-02-15 19:14:41 PST
Created attachment 362199 [details]
Patch
Comment 2 Keith Miller 2019-02-15 19:53:40 PST
Comment on attachment 362199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362199&action=review

> Source/JavaScriptCore/runtime/RegExpCache.h:51
> +        if (m_emptyRegExp)

Should we mark this likely?
Comment 3 Yusuke Suzuki 2019-02-15 20:26:31 PST
Comment on attachment 362199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362199&action=review

Thank you!

>> Source/JavaScriptCore/runtime/RegExpCache.h:51
>> +        if (m_emptyRegExp)
> 
> Should we mark this likely?

Sounds nice! Yeah, we should put LIKELY, fixed.
Comment 4 Yusuke Suzuki 2019-02-15 20:32:47 PST
Committed r241640: <https://trac.webkit.org/changeset/241640>
Comment 5 Radar WebKit Bug Importer 2019-02-15 20:33:24 PST
<rdar://problem/48133654>