Bug 194734 – https://device.login.microsoftonline.com is hanging on STP75

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[youenn fablet]

https://device.login.microsoftonline.com is hanging on STP75

[youenn fablet]

<rdar://problem/47573830>

[youenn fablet]

Created attachment 362195 [details]
Patch

[Jiewen Tan]

Comment on attachment 362195 [details]
Patch

LGTM. r=me. Could you verify that you can reproduce the bug in tlstestwebkit.org by not having the client certificate and clicking the mandatory client certificate link?

[Geoffrey Garen]

Jiewen, can you suggest a way to test this code path in an automated way?

[youenn fablet]

(In reply to Jiewen Tan from comment #3)
> Comment on attachment 362195 [details]
> Patch
> 
> LGTM. r=me. Could you verify that you can reproduce the bug in
> tlstestwebkit.org by not having the client certificate and clicking the
> mandatory client certificate link?

I cannot load tlstestwebkit.org right now and might not be able to test it soon.
It would be nice if you could validate it.
I'll put the patch in cq?

(In reply to Geoffrey Garen from comment #4)
> Jiewen, can you suggest a way to test this code path in an automated way?

I wonder whether WPT server has some support for scripting connection setup.
If not, it might be interesting to file an issue on GitHub.

[Jiewen Tan]

(In reply to Geoffrey Garen from comment #4)
> Jiewen, can you suggest a way to test this code path in an automated way?

I don't think there is any at this moment. The hardest part here is to config the server to request a client certificate.

[Geoffrey Garen]

> I don't think there is any at this moment. The hardest part here is to
> config the server to request a client certificate.

We have run-webkit-httpd, and it can run arbitrary cgi scripts. Can we use that mechanism to request a client certificate?

[WebKit Commit Bot]

Comment on attachment 362195 [details]
Patch

Clearing flags on attachment: 362195

Committed r241658: <https://trac.webkit.org/changeset/241658>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jiewen Tan]

(In reply to Geoffrey Garen from comment #7)
> > I don't think there is any at this moment. The hardest part here is to
> > config the server to request a client certificate.
> 
> We have run-webkit-httpd, and it can run arbitrary cgi scripts. Can we use
> that mechanism to request a client certificate?

Thanks Geoff for your input. I will address it in <rdar://problem/35927938>.