Bug 194732 – NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[youenn fablet]

NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics
<rdar://problem/47833813>

[youenn fablet]

Created attachment 362182 [details]
Patch

[youenn fablet]

<rdar://problem/47833813>

[Geoffrey Garen]

Comment on attachment 362182 [details]
Patch

r=me

Can we test this with an API test for TLS certificate check?

[youenn fablet]

> Can we test this with an API test for TLS certificate check?

API test probably not since we would need an HTTPS server, which we do no have yet.
We might be able to test it as a layout test with:
- a testRunner API to not respond to the certificate validation request.
- a case where network load is nullified without being cancelled. A navigation load, intercepted by fetch and leading to a fetch redirect mode=manual might do the trick.

[youenn fablet]

(In reply to youenn fablet from comment #4)
> > Can we test this with an API test for TLS certificate check?
> 
> API test probably not since we would need an HTTPS server, which we do no
> have yet.
> We might be able to test it as a layout test with:
> - a testRunner API to not respond to the certificate validation request.
To delay otherwise, the load will not complete.

[youenn fablet]

Filed https://bugs.webkit.org/show_bug.cgi?id=194737

[WebKit Commit Bot]

Comment on attachment 362182 [details]
Patch

Clearing flags on attachment: 362182

Committed r241641: <https://trac.webkit.org/changeset/241641>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.