Bug 194732 - NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics
Summary: NetworkDataTask should check its client before calling shouldCaptureExtraNetw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-15 16:40 PST by youenn fablet
Modified: 2019-02-15 20:57 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2019-02-15 16:46 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-02-15 16:40:44 PST
NetworkDataTask should check its client before calling shouldCaptureExtraNetworkLoadMetrics
<rdar://problem/47833813>
Comment 1 youenn fablet 2019-02-15 16:46:25 PST
Created attachment 362182 [details]
Patch
Comment 2 youenn fablet 2019-02-15 16:46:58 PST
<rdar://problem/47833813>
Comment 3 Geoffrey Garen 2019-02-15 19:52:02 PST
Comment on attachment 362182 [details]
Patch

r=me

Can we test this with an API test for TLS certificate check?
Comment 4 youenn fablet 2019-02-15 20:26:43 PST
> Can we test this with an API test for TLS certificate check?

API test probably not since we would need an HTTPS server, which we do no have yet.
We might be able to test it as a layout test with:
- a testRunner API to not respond to the certificate validation request.
- a case where network load is nullified without being cancelled. A navigation load, intercepted by fetch and leading to a fetch redirect mode=manual might do the trick.
Comment 5 youenn fablet 2019-02-15 20:28:58 PST
(In reply to youenn fablet from comment #4)
> > Can we test this with an API test for TLS certificate check?
> 
> API test probably not since we would need an HTTPS server, which we do no
> have yet.
> We might be able to test it as a layout test with:
> - a testRunner API to not respond to the certificate validation request.
To delay otherwise, the load will not complete.
Comment 6 youenn fablet 2019-02-15 20:29:57 PST
Filed https://bugs.webkit.org/show_bug.cgi?id=194737
Comment 7 WebKit Commit Bot 2019-02-15 20:57:14 PST
Comment on attachment 362182 [details]
Patch

Clearing flags on attachment: 362182

Committed r241641: <https://trac.webkit.org/changeset/241641>
Comment 8 WebKit Commit Bot 2019-02-15 20:57:15 PST
All reviewed patches have been landed.  Closing bug.