Bug 194729 - Web Inspector: Dark Mode: commas in CSS selectors are too dim
Summary: Web Inspector: Dark Mode: commas in CSS selectors are too dim
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-15 16:14 PST by Nikita Vasilyev
Modified: 2019-02-15 18:03 PST (History)
4 users (show)

See Also:


Attachments
[Image] Bug (85.61 KB, image/png)
2019-02-15 16:14 PST, Nikita Vasilyev
no flags Details
Patch (1.43 KB, patch)
2019-02-15 16:18 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Patch (3.46 KB, patch)
2019-02-15 16:31 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With patch applied (79.09 KB, image/png)
2019-02-15 16:33 PST, Nikita Vasilyev
no flags Details
Patch (3.62 KB, patch)
2019-02-15 17:16 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-02-15 16:14:28 PST
Created attachment 362175 [details]
[Image] Bug

Commas in CSS selectors and curly braces around style declarations are barely visible in Dark Mode.
Comment 1 Nikita Vasilyev 2019-02-15 16:18:26 PST
Created attachment 362177 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-02-15 16:18:45 PST
<rdar://problem/48128592>
Comment 3 Nikita Vasilyev 2019-02-15 16:31:36 PST
Created attachment 362180 [details]
Patch
Comment 4 Nikita Vasilyev 2019-02-15 16:33:07 PST
Created attachment 362181 [details]
[Image] With patch applied
Comment 5 Matt Baker 2019-02-15 17:02:29 PST
Comment on attachment 362180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33
>      border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2);

This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode?
Comment 6 Nikita Vasilyev 2019-02-15 17:15:50 PST
Comment on attachment 362180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362180&action=review

>> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:33
>>      border-bottom: 0.5px solid hsla(0, 0%, 0%, 0.2);
> 
> This is so similar to --text-color-quaternary in light mode, which is hsl(0, 0%, 85%). Is it possible to use --text-color-quaternary, and eliminate the @media query for dark mode?

Good point!
Comment 7 Nikita Vasilyev 2019-02-15 17:16:25 PST
Created attachment 362191 [details]
Patch
Comment 8 Matt Baker 2019-02-15 17:37:09 PST
Comment on attachment 362191 [details]
Patch

r=me, looks good!
Comment 9 WebKit Commit Bot 2019-02-15 18:03:38 PST
Comment on attachment 362191 [details]
Patch

Clearing flags on attachment: 362191

Committed r241638: <https://trac.webkit.org/changeset/241638>
Comment 10 WebKit Commit Bot 2019-02-15 18:03:39 PST
All reviewed patches have been landed.  Closing bug.