Bug 194727 - [JSC] Make builtin objects more lazily initialized under non-JIT mode
Summary: [JSC] Make builtin objects more lazily initialized under non-JIT mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-15 15:26 PST by Yusuke Suzuki
Modified: 2019-02-15 17:39 PST (History)
10 users (show)

See Also:

Attachments
Patch (25.27 KB, patch)
2019-02-15 15:31 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (25.23 KB, patch)
2019-02-15 15:38 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-15 15:26:28 PST 
[JSC] Make builtin objects more lazily initialized under non-JIT mode
Comment 1 Yusuke Suzuki 2019-02-15 15:31:58 PST 
Created attachment 362167 [details]
Patch
Comment 2 EWS Watchlist 2019-02-15 15:34:50 PST 
Attachment 362167 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2019-02-15 15:36:03 PST 
Comment on attachment 362167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362167&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Remove this part later, this should be covered by existing tests.
Comment 4 Yusuke Suzuki 2019-02-15 15:38:53 PST 
Created attachment 362170 [details]
Patch
Comment 5 Saam Barati 2019-02-15 16:27:16 PST 
Comment on attachment 362170 [details]
Patch

r=me
Comment 6 Yusuke Suzuki 2019-02-15 16:34:19 PST 
(In reply to Saam Barati from comment #5)
> Comment on attachment 362170 [details]
> Patch
> 
> r=me

Thank you!
Comment 7 Mark Lam 2019-02-15 17:12:32 PST 
Comment on attachment 362170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362170&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        accesses to these prototypes from the concurrent compiler threads, this "lazily initialize uder non-JIT"

/uder/under/

> Source/JavaScriptCore/ChangeLog:13
> +        drop some @Number referneces to avoid eager initialization. This removes some object allocations and 1

/referneces/references/
Comment 8 Yusuke Suzuki 2019-02-15 17:34:32 PST 
Comment on attachment 362170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362170&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:11
>> +        accesses to these prototypes from the concurrent compiler threads, this "lazily initialize uder non-JIT"
> 
> /uder/under/

Fixed.

>> Source/JavaScriptCore/ChangeLog:13
>> +        drop some @Number referneces to avoid eager initialization. This removes some object allocations and 1
> 
> /referneces/references/

Fixed.
Comment 9 Yusuke Suzuki 2019-02-15 17:38:25 PST 
Committed r241637: <https://trac.webkit.org/changeset/241637>
Comment 10 Radar WebKit Bug Importer 2019-02-15 17:39:36 PST 
<rdar://problem/48131308>