RESOLVED FIXED194727
[JSC] Make builtin objects more lazily initialized under non-JIT mode 
https://bugs.webkit.org/show_bug.cgi?id=194727
Summary [JSC] Make builtin objects more lazily initialized under non-JIT mode
Yusuke Suzuki
Reported 2019-02-15 15:26:28 PST
[JSC] Make builtin objects more lazily initialized under non-JIT mode
Attachments
Patch (25.27 KB, patch)
2019-02-15 15:31 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (25.23 KB, patch)
2019-02-15 15:38 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-15 15:31:58 PST
Created attachment 362167 [details] Patch
EWS Watchlist
Comment 2 2019-02-15 15:34:50 PST
Attachment 362167 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2019-02-15 15:36:03 PST
Comment on attachment 362167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362167&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Remove this part later, this should be covered by existing tests.
Yusuke Suzuki
Comment 4 2019-02-15 15:38:53 PST
Created attachment 362170 [details] Patch
Saam Barati
Comment 5 2019-02-15 16:27:16 PST
Comment on attachment 362170 [details] Patch r=me
Yusuke Suzuki
Comment 6 2019-02-15 16:34:19 PST
(In reply to Saam Barati from comment #5) > Comment on attachment 362170 [details] > Patch > > r=me Thank you!
Mark Lam
Comment 7 2019-02-15 17:12:32 PST
Comment on attachment 362170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362170&action=review > Source/JavaScriptCore/ChangeLog:11 > + accesses to these prototypes from the concurrent compiler threads, this "lazily initialize uder non-JIT" /uder/under/ > Source/JavaScriptCore/ChangeLog:13 > + drop some @Number referneces to avoid eager initialization. This removes some object allocations and 1 /referneces/references/
Yusuke Suzuki
Comment 8 2019-02-15 17:34:32 PST
Comment on attachment 362170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362170&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:11 >> + accesses to these prototypes from the concurrent compiler threads, this "lazily initialize uder non-JIT" > > /uder/under/ Fixed. >> Source/JavaScriptCore/ChangeLog:13 >> + drop some @Number referneces to avoid eager initialization. This removes some object allocations and 1 > > /referneces/references/ Fixed.
Yusuke Suzuki
Comment 9 2019-02-15 17:38:25 PST
Committed r241637: <https://trac.webkit.org/changeset/241637>
Radar WebKit Bug Importer
Comment 10 2019-02-15 17:39:36 PST
<rdar://problem/48131308>
Note You need to log in before you can comment on or make changes to this bug.