Bug 194703 - Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
Summary: Input type "formatSetInlineTextDirection" is dispatched when changing paragra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-15 07:11 PST by Wenson Hsieh
Modified: 2019-02-22 09:09 PST (History)
6 users (show)

See Also:

Attachments
Patch (26.84 KB, patch)
2019-02-15 20:52 PST, Wenson Hsieh 		rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (26.94 KB, patch)
2019-02-22 08:32 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-02-15 07:11:28 PST 
This should be formatSetBlockTextDirection instead.
Comment 1 Radar WebKit Bug Importer 2019-02-15 08:49:23 PST 
<rdar://problem/48111775>
Comment 2 Wenson Hsieh 2019-02-15 20:52:44 PST 
Created attachment 362205 [details]
Patch
Comment 3 Ryosuke Niwa 2019-02-21 21:05:05 PST 
Comment on attachment 362205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362205&action=review

> Source/WebCore/editing/EditAction.cpp:78
> +    case EditAction::SetTextWritingDirection:
> +    case EditAction::SetBaseWritingDirection:

I would have preferred using inline & block to match input type names.
Comment 4 Wenson Hsieh 2019-02-21 21:08:01 PST 
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 362205 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362205&action=review
> 
> > Source/WebCore/editing/EditAction.cpp:78
> > +    case EditAction::SetTextWritingDirection:
> > +    case EditAction::SetBaseWritingDirection:
> 
> I would have preferred using inline & block to match input type names.

Sounds good — I'll change these to EditAction::SetInlineWritingDirection and EditAction::SetBlockWritingDirection.
Comment 5 Wenson Hsieh 2019-02-22 08:32:03 PST 
Created attachment 362723 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-02-22 09:09:34 PST 
Comment on attachment 362723 [details]
Patch for landing

Clearing flags on attachment: 362723

Committed r241949: <https://trac.webkit.org/changeset/241949>