Bug 194701 - REGRESSION(r240250): buildbot console view popup is not correctly positioned since r240250
Summary: REGRESSION(r240250): buildbot console view popup is not correctly positioned ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2019-02-15 05:26 PST by Carlos Garcia Campos
Modified: 2019-02-15 23:26 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-02-15 05:26:31 PST
Steps to reproduce:

1. Go to https://build.webkit.org/console
2. Scroll down a bit
3. Click on any bubble
4. The popup is not shown, because it's positioned at the top of the page, scroll up and you will see the it there.
Comment 1 Frédéric Wang (:fredw) 2019-02-15 05:39:18 PST
showBuildBox() should probably use document.scrollingElement instead of document.body to get the scroll offset.
Comment 2 Carlos Garcia Campos 2019-02-15 05:45:04 PST
Shouldn't this be backwards compatible? There might be more websites broken.
Comment 3 Frédéric Wang (:fredw) 2019-02-15 06:40:46 PST
(In reply to Carlos Garcia Campos from comment #2)
> Shouldn't this be backwards compatible? There might be more websites broken.

Yes this change was expected to break existing content. See https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html
https://lists.webkit.org/pipermail/webkit-dev/2018-September/030122.html
for details.
Comment 4 Simon Fraser (smfr) 2019-02-15 10:53:55 PST
Does the bug reproduce in Chrome?
Comment 5 Frédéric Wang (:fredw) 2019-02-15 11:02:07 PST
(In reply to Simon Fraser (smfr) from comment #4)
> Does the bug reproduce in Chrome?

Yes it reproduces in Chrome but for some reason not in Firefox. Maybe they have different interpretation of whether to use quirks mode with XHTML pages.
Comment 6 Radar WebKit Bug Importer 2019-02-15 23:26:26 PST
<rdar://problem/48135567>