Bug 194694 – [bmalloc] NSBundle-based application name check should be executed after debug-heap environment variable check

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[bmalloc] NSBundle-based application name check should be executed after debug-heap environment variable check

[Yusuke Suzuki]

Created attachment 362103 [details]
Patch

[Mark Lam]

Comment on attachment 362103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362103&action=review

r=me with suggested improvement.

> Source/bmalloc/bmalloc/Gigacage.cpp:271
>              bool result = !PerProcess<Environment>::get()->isDebugHeapEnabled();
>              if (!result)

This is not related to your patch but since you're in this code, let's fix this too:
1. the name "result" is not meaningful.  Let's call it debugHeapEnabled instead.
2. the double negative is hard to follow.  Let's not negate the result of PerProcess<Environment>::get()->isDebugHeapEnabled(), and let's not negate the boolean value in the if check.

[Yusuke Suzuki]

Comment on attachment 362103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362103&action=review

>> Source/bmalloc/bmalloc/Gigacage.cpp:271
>>              if (!result)
> 
> This is not related to your patch but since you're in this code, let's fix this too:
> 1. the name "result" is not meaningful.  Let's call it debugHeapEnabled instead.
> 2. the double negative is hard to follow.  Let's not negate the result of PerProcess<Environment>::get()->isDebugHeapEnabled(), and let's not negate the boolean value in the if check.

Sounds nice! Fixed.

[Yusuke Suzuki]

Committed r241581: <https://trac.webkit.org/changeset/241581>

[Radar WebKit Bug Importer]

<rdar://problem/48104501>