Bug 194674 - [bmalloc] Do not start scavenger thread if we use system malloc
Summary: [bmalloc] Do not start scavenger thread if we use system malloc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-14 14:09 PST by Yusuke Suzuki
Modified: 2019-02-15 00:45 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2019-02-14 23:10 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-14 14:09:57 PST 
...
Comment 1 Yusuke Suzuki 2019-02-14 23:10:43 PST 
Created attachment 362099 [details]
Patch
Comment 2 Yusuke Suzuki 2019-02-14 23:27:20 PST 
Comment on attachment 362099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362099&action=review

> Source/bmalloc/bmalloc/Scavenger.cpp:72
> +    if (PerProcess<Environment>::get()->isDebugHeapEnabled())
> +        return;
> +

For bmalloc::Heap, Large & Small allocations go to debug heap if `isDebugHeapEnabled()` is true.
IsoHeaps also allocate memory from system malloc (fallbacking to malloc).
Comment 3 Mark Lam 2019-02-15 00:24:50 PST 
Comment on attachment 362099 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2019-02-15 00:27:27 PST 
Comment on attachment 362099 [details]
Patch

Thank you!
Comment 5 WebKit Commit Bot 2019-02-15 00:43:13 PST 
Comment on attachment 362099 [details]
Patch

Clearing flags on attachment: 362099

Committed r241580: <https://trac.webkit.org/changeset/241580>
Comment 6 WebKit Commit Bot 2019-02-15 00:43:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-02-15 00:45:37 PST 
<rdar://problem/48104040>