Bug 194673 – Web Inspector: Search: allow DOM searches to be case sensitive

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

When searching for "DIV", we're still matching <div>.

[Radar WebKit Bug Importer]

<rdar://problem/48087577>

[Nikita Vasilyev]

(In reply to Devin Rousso from comment #0)
> When searching for "DIV", we're still matching <div>.

This seems fine to me. What's the real-world use case here?

[Devin Rousso]

(In reply to Nikita Vasilyev from comment #2)
> (In reply to Devin Rousso from comment #0)
> > When searching for "DIV", we're still matching <div>.
> 
> This seems fine to me. What's the real-world use case here?
Ok maybe that was a bad example.  If I have

    <div class="CLASS">CONTENT"</div>

and I searched for "class" or "content", it would still match.  We are unable to do any sort of case sensitivity (we convert all queries to lowercase, as well as the text through which we're searching).

We could also _try_ to make regex searching work, but that's much harder to search across nodes (e.g. /><div>(\w+)<\/div/ wouldn't work).  If we limit the regex search to within a specific node (as it does now), then that shouldn't be too hard.

[Devin Rousso]

Created attachment 364427 [details]
Patch

[EWS Watchlist]

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

[WebKit Commit Bot]

Comment on attachment 364427 [details]
Patch

Clearing flags on attachment: 364427

Committed r243207: <https://trac.webkit.org/changeset/243207>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 364427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364427&action=review

Awesome!

> Source/WebCore/inspector/InspectorNodeFinder.h:67
> +    bool m_caseSensitive;
> +
> +    ListHashSet<Node*> m_results;
>      bool m_startTagFound;

Nit: Maybe group the bools together.

> Source/WebCore/inspector/agents/InspectorDOMAgent.h:137
> -    void performSearch(ErrorString&, const String& whitespaceTrimmedQuery, const JSON::Array* nodeIds, String* searchId, int* resultCount) override;
> +    void performSearch(ErrorString&, const String& query, const JSON::Array* nodeIds, const bool* caseSensitive, String* searchId, int* resultCount) override;

Should notify ITMLKit folks.