<rdar://problem/39066529>
Created attachment 362074 [details] First pass
Comment on attachment 362074 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=362074&action=review > Source/WebCore/platform/ios/PasteboardIOS.mm:291 > + bool canReadAttachment = policy == WebContentReadingPolicy::AnyType && RuntimeEnabledFeatures::sharedFeatures().attachmentElementEnabled(); Maybe put attachmentELementEnabled outside the loop and bail from this whole section if it's not set? > Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:34 > - typedef std::tuple<WKBundlePageEditorClientV0, WKBundlePageEditorClientV1, WKBundlePageEditorClientV2> Versions; > + typedef std::tuple<WKBundlePageEditorClientV0, WKBundlePageEditorClientV1> Versions; Did we ever ship this? I think you noted that nobody adopted, but did we ship it?
Comment on attachment 362074 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=362074&action=review >> Source/WebCore/platform/ios/PasteboardIOS.mm:291 >> + bool canReadAttachment = policy == WebContentReadingPolicy::AnyType && RuntimeEnabledFeatures::sharedFeatures().attachmentElementEnabled(); > > Maybe put attachmentELementEnabled outside the loop and bail from this whole section if it's not set? 👍 >> Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:34 >> + typedef std::tuple<WKBundlePageEditorClientV0, WKBundlePageEditorClientV1> Versions; > > Did we ever ship this? I think you noted that nobody adopted, but did we ship it? Regrettably, this did ship :( Per IRC conversation, I'll maintain bincompat in this patch, and then see if I can remove it in a separate patch.
Created attachment 362338 [details] Patch for EWS
Created attachment 362341 [details] Patch for EWS
Comment on attachment 362341 [details] Patch for EWS Clearing flags on attachment: 362341 Committed r241749: <https://trac.webkit.org/changeset/241749>
All reviewed patches have been landed. Closing bug.