Bug 194669 – [ Mac WK2 ] REGRESSION (r229726) Layout Test http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html is a flaky failure

• Status: CLOSED
• Resolution: FIXED
• Component: Tools / Tests

[Shawn Roberts]

The following layout test is failing on Mac WK2

http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html

Probable cause:

It appears test became flaky after test was changed with r229726. While investigating a high number of recently flaky security tests I was able to bisect this test to this specific revision. Tests prior to this revision result in 100% failure.

Reproducible with:

run-webkit-tests t229726 http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html --iterations 500 -f

I am unsure if related, but there are several tests in this tree that have recently become flaky on the dashboard. All but the one above are not reproducible locally. 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Fblock-all-mixed-content%2Finsecure-image-in-main-frame.html
http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Fblock-all-mixed-content%2F

Diff:

@@ -7,17 +7,6 @@
 main frame - didFinishDocumentLoadForFrame
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame
-This test opens a window and loads an insecure image. We should trigger a mixed content block because the main frame in the window has CSP directive block-all-mixed-content.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 15766)
+FAIL: Timed out waiting for notifyDone to be called
 
-documentURI: https://127.0.0.1:8443/security/contentSecurityPolicy/block-all-mixed-content/resources/frame-with-insecure-image.html
-referrer: http://127.0.0.1:8000/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html
-blockedURI: http://127.0.0.1:8000
-violatedDirective: block-all-mixed-content
-effectiveDirective: block-all-mixed-content
-originalPolicy: block-all-mixed-content
-sourceFile: 
-lineNumber: 0
-columnNumber: 0
-statusCode: 0
-
-

[Radar WebKit Bug Importer]

<rdar://problem/48086580>

[Chris Dumez]

Doesn't seem to be happening anymore.

[Shawn Roberts]

Cannot reproduce locally using 1 child process, and bots seem happy now.

Closing bug.