Bug 194666 – Make navigator.mediaDevices SecureContext

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Make navigator.mediaDevices SecureContext

[youenn fablet]

Created attachment 362061 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/48088224>

[youenn fablet]

Created attachment 362076 [details]
Patch

[Eric Carlson]

Comment on attachment 362076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362076&action=review

> Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl:35
> +    [SameObject, SecureContext, ContextHasMediaDevices] readonly attribute MediaDevices mediaDevices;

Nit: I think something like "ContextAllowsMediaDevices" might be clearer.

[youenn fablet]

(In reply to Eric Carlson from comment #4)
> Comment on attachment 362076 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362076&action=review
> 
> > Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl:35
> > +    [SameObject, SecureContext, ContextHasMediaDevices] readonly attribute MediaDevices mediaDevices;
> 
> Nit: I think something like "ContextAllowsMediaDevices" might be clearer.

Yes, makes sense!

[youenn fablet]

Created attachment 362128 [details]
Patch for landing

[Jon Lee]

Comment on attachment 362128 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=362128&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3695
> +                . "|| jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext()->allowsMediaDevices())");

Do we not add binding generator tests for extended attributes such as these?

[youenn fablet]

(In reply to Jon Lee from comment #7)
> Comment on attachment 362128 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362128&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3695
> > +                . "|| jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext()->allowsMediaDevices())");
> 
> Do we not add binding generator tests for extended attributes such as these?

Filed https://bugs.webkit.org/show_bug.cgi?id=194713

[WebKit Commit Bot]

Comment on attachment 362128 [details]
Patch for landing

Clearing flags on attachment: 362128

Committed r241602: <https://trac.webkit.org/changeset/241602>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.