Make navigator.mediaDevices SecureContext
Created attachment 362061 [details] Patch
<rdar://problem/48088224>
Created attachment 362076 [details] Patch
Comment on attachment 362076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362076&action=review > Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl:35 > + [SameObject, SecureContext, ContextHasMediaDevices] readonly attribute MediaDevices mediaDevices; Nit: I think something like "ContextAllowsMediaDevices" might be clearer.
(In reply to Eric Carlson from comment #4) > Comment on attachment 362076 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362076&action=review > > > Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl:35 > > + [SameObject, SecureContext, ContextHasMediaDevices] readonly attribute MediaDevices mediaDevices; > > Nit: I think something like "ContextAllowsMediaDevices" might be clearer. Yes, makes sense!
Created attachment 362128 [details] Patch for landing
Comment on attachment 362128 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=362128&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3695 > + . "|| jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext()->allowsMediaDevices())"); Do we not add binding generator tests for extended attributes such as these?
(In reply to Jon Lee from comment #7) > Comment on attachment 362128 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362128&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3695 > > + . "|| jsCast<JSDOMGlobalObject*>(" . $globalObjectPtr . ")->scriptExecutionContext()->allowsMediaDevices())"); > > Do we not add binding generator tests for extended attributes such as these? Filed https://bugs.webkit.org/show_bug.cgi?id=194713
Comment on attachment 362128 [details] Patch for landing Clearing flags on attachment: 362128 Committed r241602: <https://trac.webkit.org/changeset/241602>
All reviewed patches have been landed. Closing bug.