Bug 194657 - Sample domainsVisited diagnostic logging
Summary: Sample domainsVisited diagnostic logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-14 10:30 PST by Chris Dumez
Modified: 2019-02-16 13:52 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2019-02-14 10:32 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-02-14 10:30:43 PST 
Sample domainsVisited diagnostic logging, we are getting a lot of data from this key and this is hurting our other keys.
Comment 1 Chris Dumez 2019-02-14 10:32:27 PST 
Created attachment 362033 [details]
Patch
Comment 2 Chris Dumez 2019-02-14 10:58:00 PST 
<rdar://problem/48079857>
Comment 3 Chris Dumez 2019-02-15 16:36:11 PST 
Comment on attachment 362033 [details]
Patch

Clearing flags on attachment: 362033

Committed r241632: <https://trac.webkit.org/changeset/241632>
Comment 4 Chris Dumez 2019-02-15 16:36:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Geoffrey Garen 2019-02-16 13:52:03 PST 
Is it sufficient to change domainVisitedKey to sampling, without also changing domainCausingJetsamKey and domainCausingEnergyDrainKey?