AX: ARIA Reflection was disabled in error r236522 from bug 151380 disabled the ARIAReflectionEnabled flag, presumably in error. https://bugs.webkit.org/show_bug.cgi?id=151380#c18 The automated tests did not catch the fault because the test runner overrides the flag: ~src/WebKit/Tools/WebKitTestRunner/TestController.cpp: 827: WKPreferencesSetAriaReflectionEnabled(preferences, true); So the fix may be to revert the AriaReflectionEnabled value in WebPreferences.yaml and remove the test override.
<rdar://problem/48068336>
Created attachment 362005 [details] patch
Comment on attachment 362005 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=362005&action=review > Source/WebKit/Shared/WebPreferences.yaml:1438 > + defaultValue: true Should this patch pull the test override out too? ~src/WebKit/Tools/WebKitTestRunner/TestController.cpp: 827: WKPreferencesSetAriaReflectionEnabled(preferences, true);
Comment on attachment 362005 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=362005&action=review >> Source/WebKit/Shared/WebPreferences.yaml:1438 >> + defaultValue: true > > Should this patch pull the test override out too? > > ~src/WebKit/Tools/WebKitTestRunner/TestController.cpp: > 827: WKPreferencesSetAriaReflectionEnabled(preferences, true); will wait for Ryosuke to weigh in on that
Comment on attachment 362005 [details] patch We probably should remove the override in the test runner as well
Created attachment 362016 [details] Landing patch
Comment on attachment 362016 [details] Landing patch Clearing flags on attachment: 362016 Committed r241549: <https://trac.webkit.org/changeset/241549>
All reviewed patches have been landed. Closing bug.