Bug 194645 - Clean up WKActionSheetAssistant's use of LaunchServices
Summary: Clean up WKActionSheetAssistant's use of LaunchServices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-13 23:32 PST by Tim Horton
Modified: 2019-04-24 12:07 PDT (History)
11 users (show)

See Also:


Attachments
Patch (8.72 KB, patch)
2019-02-13 23:33 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (10.01 KB, patch)
2019-04-23 19:01 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-02-13 23:32:04 PST
Clean up WKActionSheetAssistant's use of LaunchServices
Comment 1 Tim Horton 2019-02-13 23:33:32 PST
Created attachment 361998 [details]
Patch
Comment 2 Tim Horton 2019-02-13 23:33:35 PST
<rdar://problem/47707952>
Comment 3 Andy Estes 2019-02-14 13:25:55 PST
r=me if you fix iOS EWS
Comment 4 Tim Horton 2019-02-14 13:30:19 PST
(In reply to Andy Estes from comment #3)
> r=me if you fix iOS EWS

Naaahhhh
Comment 5 Tim Horton 2019-04-23 19:01:29 PDT
Created attachment 368101 [details]
Patch
Comment 6 Andy Estes 2019-04-24 10:39:09 PDT
Comment on attachment 368101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368101&action=review

> Source/WTF/wtf/Platform.h:1530
>  #if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000)
> +#define HAVE_APP_LINKS_WITH_ISENABLED 1
>  #define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1
>  #endif

Should this all be in AdditionalFeatureDefines?
Comment 7 WebKit Commit Bot 2019-04-24 12:07:43 PDT
Comment on attachment 368101 [details]
Patch

Clearing flags on attachment: 368101

Committed r244600: <https://trac.webkit.org/changeset/244600>
Comment 8 WebKit Commit Bot 2019-04-24 12:07:45 PDT
All reviewed patches have been landed.  Closing bug.