WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194645
Clean up WKActionSheetAssistant's use of LaunchServices
https://bugs.webkit.org/show_bug.cgi?id=194645
Summary
Clean up WKActionSheetAssistant's use of LaunchServices
Tim Horton
Reported
2019-02-13 23:32:04 PST
Clean up WKActionSheetAssistant's use of LaunchServices
Attachments
Patch
(8.72 KB, patch)
2019-02-13 23:33 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(10.01 KB, patch)
2019-04-23 19:01 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2019-02-13 23:33:32 PST
Created
attachment 361998
[details]
Patch
Tim Horton
Comment 2
2019-02-13 23:33:35 PST
<
rdar://problem/47707952
>
Andy Estes
Comment 3
2019-02-14 13:25:55 PST
r=me if you fix iOS EWS
Tim Horton
Comment 4
2019-02-14 13:30:19 PST
(In reply to Andy Estes from
comment #3
)
> r=me if you fix iOS EWS
Naaahhhh
Tim Horton
Comment 5
2019-04-23 19:01:29 PDT
Created
attachment 368101
[details]
Patch
Andy Estes
Comment 6
2019-04-24 10:39:09 PDT
Comment on
attachment 368101
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=368101&action=review
> Source/WTF/wtf/Platform.h:1530 > #if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) > +#define HAVE_APP_LINKS_WITH_ISENABLED 1 > #define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1 > #endif
Should this all be in AdditionalFeatureDefines?
WebKit Commit Bot
Comment 7
2019-04-24 12:07:43 PDT
Comment on
attachment 368101
[details]
Patch Clearing flags on attachment: 368101 Committed
r244600
: <
https://trac.webkit.org/changeset/244600
>
WebKit Commit Bot
Comment 8
2019-04-24 12:07:45 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug