Bug 194641 - Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
Summary: Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHie...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-13 21:36 PST by Ryosuke Niwa
Modified: 2019-02-13 22:47 PST (History)
5 users (show)

See Also:

Attachments
Fixes the bug (3.37 KB, patch)
2019-02-13 21:43 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-02-13 21:36:10 PST 
When WKBundleFrameGetParentFrame is called inside PageLoaderClient's didRemoveFrameFromHierarchy,
we crash WebFrame::parentFrame() because owner element's document no longer has a frame.
Comment 1 Ryosuke Niwa 2019-02-13 21:43:21 PST 
Created attachment 361994 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2019-02-13 21:43:46 PST 
<rdar://problem/31441007>
Comment 3 Geoffrey Garen 2019-02-13 22:09:18 PST 
Comment on attachment 361994 [details]
Fixes the bug

r=me
Comment 4 Ryosuke Niwa 2019-02-13 22:47:33 PST 
Comment on attachment 361994 [details]
Fixes the bug

Clearing flags on attachment: 361994

Committed r241500: <https://trac.webkit.org/changeset/241500>
Comment 5 Ryosuke Niwa 2019-02-13 22:47:35 PST 
All reviewed patches have been landed.  Closing bug.