WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194623
Web Inspector: don't include accessibility role in DOM.Node object payloads
https://bugs.webkit.org/show_bug.cgi?id=194623
Summary
Web Inspector: don't include accessibility role in DOM.Node object payloads
Blaze Burg
Reported
2019-02-13 16:27:26 PST
This is complicated to fetch at all the points where we want to build and push nodes immediately. Turning on AX often indirectly causes style recalc and layout. This is bad because we are often building nodes in the first place due to a DOM node tree update (i.e., NodeInserted).
Attachments
Patch
(4.29 KB, patch)
2019-02-13 16:31 PST
,
Blaze Burg
hi
: review+
hi
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Blaze Burg
Comment 1
2019-02-13 16:27:42 PST
<
rdar://problem/36384037
>
Blaze Burg
Comment 2
2019-02-13 16:31:48 PST
Created
attachment 361957
[details]
Patch
EWS Watchlist
Comment 3
2019-02-13 16:33:52 PST
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Devin Rousso
Comment 4
2019-02-13 16:39:49 PST
Comment on
attachment 361957
[details]
Patch r=me We should also update `WI.DOMNode.prototype.accessibilityProperties` to save the role to `_computedRole` so that `WI.DOMNode.prototype.computedRole` actually returns a value once we've requested accessibility info at least once (this is needed by `WI.roleSelectorForNode`).
Blaze Burg
Comment 5
2019-02-14 09:06:13 PST
Committed
r241547
: <
https://trac.webkit.org/changeset/241547
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug