Bug 194623 - Web Inspector: don't include accessibility role in DOM.Node object payloads
Summary: Web Inspector: don't include accessibility role in DOM.Node object payloads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-13 16:27 PST by Brian Burg
Modified: 2019-02-14 09:06 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.29 KB, patch)
2019-02-13 16:31 PST, Brian Burg 		drousso: review+
drousso: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2019-02-13 16:27:26 PST 
This is complicated to fetch at all the points where we want to build and push nodes immediately. Turning on AX often indirectly causes style recalc and layout. This is bad because we are often building nodes in the first place due to a DOM node tree update (i.e., NodeInserted).
Comment 1 Brian Burg 2019-02-13 16:27:42 PST 
<rdar://problem/36384037>
Comment 2 Brian Burg 2019-02-13 16:31:48 PST 
Created attachment 361957 [details]
Patch
Comment 3 EWS Watchlist 2019-02-13 16:33:52 PST 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 4 Devin Rousso 2019-02-13 16:39:49 PST 
Comment on attachment 361957 [details]
Patch

r=me

We should also update `WI.DOMNode.prototype.accessibilityProperties` to save the role to `_computedRole` so that `WI.DOMNode.prototype.computedRole` actually returns a value once we've requested accessibility info at least once (this is needed by `WI.roleSelectorForNode`).
Comment 5 Brian Burg 2019-02-14 09:06:13 PST 
Committed r241547: <https://trac.webkit.org/changeset/241547>