WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194622
[LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
https://bugs.webkit.org/show_bug.cgi?id=194622
Summary
[LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
zalan
Reported
2019-02-13 16:09:57 PST
This is something I actually couldn't find in
https://www.w3.org/TR/CSS22/box.html#collapsing-margins
"A box's own margins collapse if the 'min-height' property is zero, and it has neither top or bottom borders nor top or bottom padding, and it has a 'height' of either 0 or 'auto', and it does not contain a line box, and all of its in-flow children's margins (if any) collapse."
Attachments
Patch
(5.44 KB, patch)
2019-02-13 16:47 PST
,
zalan
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2019-02-13 16:47:56 PST
Created
attachment 361964
[details]
Patch
Antti Koivisto
Comment 2
2019-02-14 07:33:25 PST
Comment on
attachment 361964
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=361964&action=review
> LayoutTests/fast/block/block-only/block-replaced-with-vertical-margins-expected.html:3 > + min-height: 0.1px;
Seems little hackish.
zalan
Comment 3
2019-02-14 08:44:47 PST
Committed
r241546
: <
https://trac.webkit.org/changeset/241546
>
Radar WebKit Bug Importer
Comment 4
2019-02-14 08:49:40 PST
<
rdar://problem/48075210
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug