Bug 194621 – [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.

[Jer Noble]

<rdar://problem/48002560>

[Jer Noble]

Created attachment 361951 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 361951 [details]
Patch

Clearing flags on attachment: 361951

Committed r241492: <https://trac.webkit.org/changeset/241492>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jon Lee]

Comment on attachment 361951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361951&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287
> +            this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode);

@Antoine, why was rAF used in the first place?
@Jer, are there other instances where rAF is being used for similar purposes that should be reconsidered?

[Antoine Quint]

(In reply to Jon Lee from comment #5)
> Comment on attachment 361951 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361951&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287
> > +            this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode);
> 
> @Antoine, why was rAF used in the first place?


I don't know for sure, but I would wager this was to do with flakiness.