Bug 194621 - [Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
Summary: [Mac] PiP window can get "stuck" if PiP is closed while Safari window is mini...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-13 15:51 PST by Jer Noble
Modified: 2019-02-14 06:26 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2019-02-13 15:55 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-02-13 15:51:59 PST
[Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
Comment 1 Jer Noble 2019-02-13 15:53:35 PST
<rdar://problem/48002560>
Comment 2 Jer Noble 2019-02-13 15:55:43 PST
Created attachment 361951 [details]
Patch
Comment 3 WebKit Commit Bot 2019-02-13 18:28:53 PST
Comment on attachment 361951 [details]
Patch

Clearing flags on attachment: 361951

Committed r241492: <https://trac.webkit.org/changeset/241492>
Comment 4 WebKit Commit Bot 2019-02-13 18:28:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Jon Lee 2019-02-13 18:36:12 PST
Comment on attachment 361951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361951&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287
> +            this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode);

@Antoine, why was rAF used in the first place?
@Jer, are there other instances where rAF is being used for similar purposes that should be reconsidered?
Comment 6 Antoine Quint 2019-02-14 06:26:49 PST
(In reply to Jon Lee from comment #5)
> Comment on attachment 361951 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361951&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:287
> > +            this.host.setPreparedToReturnVideoLayerToInline(this.media.webkitPresentationMode !== PiPMode);
> 
> @Antoine, why was rAF used in the first place?


I don't know for sure, but I would wager this was to do with flakiness.