We should not accept Ad Click Attributions where the current website and the addestination attribute are same-site. The site doesn't need attributions sent for itself.
<rdar://problem/47890018>
Created attachment 361950 [details] Patch
Comment on attachment 361950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361950&action=review LGTM except for the lack of the clarifications. John explained that to me personally. Please add those explanations to the change log before landing. r=me. > Source/WebCore/ChangeLog:9 > + Updated existing test. I guess some clarifications of the necessity of this patch is needed here. > Source/WebCore/html/HTMLAnchorElement.cpp:449 > + if (documentDomain == adDestinationHost) { It is a bit unfortunate that platforms that don't have PUBLIC_SUFFIX_LIST get different behaviors.
(In reply to Jiewen Tan from comment #3) > Comment on attachment 361950 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361950&action=review > > LGTM except for the lack of the clarifications. John explained that to me > personally. Please add those explanations to the change log before landing. Good idea. Will do. > r=me. > > > Source/WebCore/ChangeLog:9 > > + Updated existing test. > > I guess some clarifications of the necessity of this patch is needed here. Yup. > > Source/WebCore/html/HTMLAnchorElement.cpp:449 > > + if (documentDomain == adDestinationHost) { > > It is a bit unfortunate that platforms that don't have PUBLIC_SUFFIX_LIST > get different behaviors. Yes. I'll make a note of that in the change log too. Thanks for the review, Jiewen!
I will wait for the bots to go green before landing.
Created attachment 361967 [details] Patch for landing
Comment on attachment 361967 [details] Patch for landing Clearing flags on attachment: 361967 Committed r241490: <https://trac.webkit.org/changeset/241490>
All reviewed patches have been landed. Closing bug.