Bug 194598 - [EWS] status bubble should show Failed to apply when a patch doesn't apply on any EWS queue
Summary: [EWS] status bubble should show Failed to apply when a patch doesn't apply on...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
: 201184 (view as bug list)
Depends on: 197522
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-13 10:45 PST by Aakash Jain
Modified: 2019-09-18 12:49 PDT (History)
6 users (show)

See Also:

Attachments
WIP (2.24 KB, patch)
2019-07-21 17:44 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-13 10:45:10 PST 
status bubble generated by ews-app should show Failed to apply when a patch doesn't apply on any EWS queue.
Comment 1 Aakash Jain 2019-07-21 17:44:43 PDT 
Created attachment 374584 [details]
WIP
Comment 2 Aakash Jain 2019-07-21 17:46:52 PDT 
Need to design a webpage which will open on clicking the 'patch does not apply to trunk of repository' button.
Comment 3 Jonathan Bedard 2019-07-22 07:54:41 PDT 
Comment on attachment 374584 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=374584&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:238
> +        failed_to_apply = all(map(lambda bubble: "failed_to_apply" in bubble or bubble['state'] == 'none', bubbles))

Shouldn't this be:

bubble.get('failed_to_apply') since "bubble['failed_to_apply'] = False" seems perfectly valid.
Comment 4 Radar WebKit Bug Importer 2019-07-24 10:58:41 PDT 
<rdar://problem/53503951>
Comment 5 Aakash Jain 2019-08-27 09:35:48 PDT 
*** Bug 201184 has been marked as a duplicate of this bug. ***