Make WebRTCUnifiedPlanEnabled true by default
Created attachment 361923 [details] Patch
<rdar://problem/48042888>
Comment on attachment 361923 [details] Patch Rejecting attachment 361923 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 361923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=361923&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=194595&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 361923 from bug 194595. Fetching: https://bugs.webkit.org/attachment.cgi?id=361923 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog M Source/WebKit/Shared/WebPreferences.yaml Committed r241452 fatal: Unable to create '/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock': File exists. Another git process seems to be running in this repository, e.g. an editor opened by 'git commit'. Please make sure all processes are terminated then try again. If it still fails, a git process may have crashed in this repository earlier: remove the file manually to continue. write-tree: command returned error: 128 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog M Source/WebKit/Shared/WebPreferences.yaml Committed r241452 fatal: Unable to create '/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock': File exists. Another git process seems to be running in this repository, e.g. an editor opened by 'git commit'. Please make sure all processes are terminated then try again. If it still fails, a git process may have crashed in this repository earlier: remove the file manually to continue. write-tree: command returned error: 128 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 898e28d9b03..4e47e4f74cc master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 241448 = 898e28d9b0368fe03c07f87edcab2e4ede1f241d r241449 = 274a8e1fb29505562053ccdfd4e867a69cd7c138 r241450 = 34567a6878937b6da4f9de9449f5ba2f002e6053 r241451 = 4e47e4f74cc461b732e1e608881a5633810304ca Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11137306
Need to drop category: experimental now.
(In reply to Michael Catanzaro from comment #4) > Need to drop category: experimental now. The category 'experimental' allows to keep it in Safari Experimental Features which is nice to have during adoption of the feature. It allows web devs to test with and without, check what breaks... Agreed this option should be removed from the experimental category at some point.
Comment on attachment 361923 [details] Patch Rejecting attachment 361923 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 361923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=361923&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=194595&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 361923 from bug 194595. Fetching: https://bugs.webkit.org/attachment.cgi?id=361923 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Shared/WebPreferences.yaml Hunk #1 FAILED at 530. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/WebPreferences.yaml.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11146825
https://trac.webkit.org/changeset/241452/webkit