Bug 194581 - Remove unnecessary null check in bindings.
Summary: Remove unnecessary null check in bindings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on: 194530
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-12 22:02 PST by Mark Lam
Modified: 2019-02-12 23:14 PST (History)
5 users (show)

See Also:


Attachments
proposed patch. (2.40 KB, patch)
2019-02-12 22:09 PST, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (2.40 KB, patch)
2019-02-12 22:12 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-02-12 22:02:55 PST
See https://bugs.webkit.org/show_bug.cgi?id=194530#c10:

It is always save to call visitor.containsOpaqueRoot(root) with a null root pointer.  It will just return false.  Since we don't expect the root pointer to be null in the common case, having a null check here is also not be optimal.  We'll remove this unneeded null check.
Comment 1 Mark Lam 2019-02-12 22:09:47 PST
Created attachment 361893 [details]
proposed patch.
Comment 2 Mark Lam 2019-02-12 22:12:27 PST
Created attachment 361894 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2019-02-12 22:47:19 PST
Comment on attachment 361894 [details]
proposed patch.

r=me
Comment 4 WebKit Commit Bot 2019-02-12 23:13:12 PST
Comment on attachment 361894 [details]
proposed patch.

Clearing flags on attachment: 361894

Committed r241348: <https://trac.webkit.org/changeset/241348>
Comment 5 WebKit Commit Bot 2019-02-12 23:13:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-12 23:14:24 PST
<rdar://problem/48029348>