Bug 194570 - Branch-Specific: Revert ability to set programmatic focus when hardware keyboard is attached
Summary: Branch-Specific: Revert ability to set programmatic focus when hardware keybo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 190017
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-12 17:02 PST by Brent Fulgham
Modified: 2019-02-14 08:08 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2019-02-12 17:05 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-02-12 17:02:49 PST 
Modifying WebKit to allow programmatic focus when a hardware keyboard is attached doesn't work well enough to ship. We should turn this off in our safari-607-branch.
Comment 1 Brent Fulgham 2019-02-12 17:04:09 PST 
<rdar://problem/47673836>
Comment 2 Brent Fulgham 2019-02-12 17:05:22 PST 
Created attachment 361870 [details]
Patch
Comment 3 Daniel Bates 2019-02-12 18:24:32 PST 
Comment on attachment 361870 [details]
Patch

Ensure this doesn’t cause any API test failures. I think we may have some tests.
Comment 4 Brent Fulgham 2019-02-14 08:08:41 PST 
I ran all API tests with and without this patch and had the same results for all tests.

Clearing flag because we do not intend to land this in trunk.