RESOLVED FIXED Bug 194566
Create a randomized free list for new StructureIDs on StructureIDTable resize. 
https://bugs.webkit.org/show_bug.cgi?id=194566
Summary Create a randomized free list for new StructureIDs on StructureIDTable resize.
Mark Lam
Reported 2019-02-12 16:31:19 PST
<rdar://problem/47975502>
Attachments
proposed patch. (4.83 KB, patch)
2019-02-12 16:34 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (7.69 KB, patch)
2019-02-12 22:55 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-02-12 16:34:01 PST
Created attachment 361863 [details] proposed patch.
Saam Barati
Comment 2 2019-02-12 20:50:16 PST
Comment on attachment 361863 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=361863&action=review > Source/JavaScriptCore/runtime/StructureIDTable.cpp:71 > + table()[pick].offset = m_firstFreeOffset; Why not just assign to zero?
Mark Lam
Comment 3 2019-02-12 20:52:09 PST
Comment on attachment 361863 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=361863&action=review >> Source/JavaScriptCore/runtime/StructureIDTable.cpp:71 >> + table()[pick].offset = m_firstFreeOffset; > > Why not just assign to zero? Oops. This is a bug. It should be: table()[pick].offset = head;
Mark Lam
Comment 4 2019-02-12 20:53:24 PST
Looks like I should fix the 32-bit issues too. Probably something trivial.
Mark Lam
Comment 5 2019-02-12 22:55:51 PST
Created attachment 361899 [details] proposed patch.
Michael Saboff
Comment 6 2019-02-13 10:35:30 PST
Comment on attachment 361899 [details] proposed patch. r=me
Mark Lam
Comment 7 2019-02-13 12:33:23 PST
Thanks for the review. I re-tested the fixed patch with the CLI JetStream2, and perf appears to be neutral. Will land now.
Mark Lam
Comment 8 2019-02-13 12:35:06 PST
Landed in r241449: <http://trac.webkit.org/r241449>.
Note You need to log in before you can comment on or make changes to this bug.