Bug 194563 - Fix the Windows build after r241320
Summary: Fix the Windows build after r241320
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2019-02-12 16:22 PST by Wenson Hsieh
Modified: 2019-02-12 17:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2019-02-12 16:25 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2019-02-12 16:26 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-02-12 16:22:09 PST 
Filing a bug so I can test my change against the Windows EWS bot.
Comment 1 Wenson Hsieh 2019-02-12 16:25:39 PST 
c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\page\frame.cpp(689): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]
c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\page\frame.cpp(689): warning C4715: 'WebCore::Frame::requestDOMPasteAccess': not all control paths return a value [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]
Comment 2 Wenson Hsieh 2019-02-12 16:25:47 PST 
Created attachment 361861 [details]
Patch
Comment 3 Wenson Hsieh 2019-02-12 16:26:37 PST 
Created attachment 361862 [details]
Patch
Comment 4 Wenson Hsieh 2019-02-12 17:08:10 PST 
It looks like Alex just landed a fix for this in r241331.