Bug 194557 - Find on Page shouldn't zoom in on matches
Summary: Find on Page shouldn't zoom in on matches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-12 14:24 PST by Tim Horton
Modified: 2019-02-12 15:33 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.16 KB, patch)
2019-02-12 14:25 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-02-12 14:24:43 PST
Find on Page shouldn't zoom in on matches
Comment 1 Tim Horton 2019-02-12 14:25:13 PST
Created attachment 361841 [details]
Patch
Comment 2 Tim Horton 2019-02-12 14:25:25 PST
<rdar://problem/42087017>
Comment 3 Tim Horton 2019-02-12 14:26:32 PST
I waffled a bit about adding this to SmartMagnificationController since it is explicitly not magnification. But I'd rather there than a new message in one of the god classes, and I think we could rename and push SmartMagnificationController in the direction of being the standard "reveal stuff" mechanism instead of just being about smart magnification.
Comment 4 Wenson Hsieh 2019-02-12 14:27:30 PST
Comment on attachment 361841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361841&action=review

r=mews

> Source/WebKit/UIProcess/ios/SmartMagnificationController.mm:131
> +void SmartMagnificationController::scrollToRect(FloatPoint origin, FloatRect targetRect)

Nit - could be const FloatPoint& and const FloatRect&. Do we also need WebCore:: here?
Comment 5 Tim Horton 2019-02-12 14:31:41 PST
(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 361841 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361841&action=review
> 
> r=mews

Thankyou.

> > Source/WebKit/UIProcess/ios/SmartMagnificationController.mm:131
> > +void SmartMagnificationController::scrollToRect(FloatPoint origin, FloatRect targetRect)
> 
> Nit - could be const FloatPoint& and const FloatRect&.

Could be but why do that when they fit in a register :P (/me channels andersca)

> Do we also need WebCore:: here?

No, there's a 'using namespace WebCore' inside the 'namespace WebKit' (which is fine).
Comment 6 WebKit Commit Bot 2019-02-12 15:33:29 PST
Comment on attachment 361841 [details]
Patch

Clearing flags on attachment: 361841

Committed r241323: <https://trac.webkit.org/changeset/241323>
Comment 7 WebKit Commit Bot 2019-02-12 15:33:30 PST
All reviewed patches have been landed.  Closing bug.