Bug 194557 – Find on Page shouldn't zoom in on matches

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Find on Page shouldn't zoom in on matches

[Tim Horton]

Created attachment 361841 [details]
Patch

[Tim Horton]

<rdar://problem/42087017>

[Tim Horton]

I waffled a bit about adding this to SmartMagnificationController since it is explicitly not magnification. But I'd rather there than a new message in one of the god classes, and I think we could rename and push SmartMagnificationController in the direction of being the standard "reveal stuff" mechanism instead of just being about smart magnification.

[Wenson Hsieh]

Comment on attachment 361841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361841&action=review

r=mews

> Source/WebKit/UIProcess/ios/SmartMagnificationController.mm:131
> +void SmartMagnificationController::scrollToRect(FloatPoint origin, FloatRect targetRect)

Nit - could be const FloatPoint& and const FloatRect&. Do we also need WebCore:: here?

[Tim Horton]

(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 361841 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361841&action=review
> 
> r=mews

Thankyou.

> > Source/WebKit/UIProcess/ios/SmartMagnificationController.mm:131
> > +void SmartMagnificationController::scrollToRect(FloatPoint origin, FloatRect targetRect)
> 
> Nit - could be const FloatPoint& and const FloatRect&.

Could be but why do that when they fit in a register :P (/me channels andersca)

> Do we also need WebCore:: here?

No, there's a 'using namespace WebCore' inside the 'namespace WebKit' (which is fine).

[WebKit Commit Bot]

Comment on attachment 361841 [details]
Patch

Clearing flags on attachment: 361841

Committed r241323: <https://trac.webkit.org/changeset/241323>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.