Bug 194552 – [WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Justin Fan]

[WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions

[Justin Fan]

Created attachment 361825 [details]
Patch

[Justin Fan]

Created attachment 361829 [details]
Patch

[Justin Fan]

Created attachment 361838 [details]
Patch

[Justin Fan]

Created attachment 361839 [details]
Patch

[Dean Jackson]

Comment on attachment 361838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361838&action=review

r=me but make sure not to commit the conflicted Sources.txt

> Source/WebCore/Sources.txt:2774
> +<<<<<<< HEAD
>  JSGPUColor.cpp
> +=======
> +JSGPUBufferDescriptor.cpp
> +JSGPUBufferUsage.cpp
> +>>>>>>> 57c93d27a40... Removed WebGPUBufferDescriptor/Usage for GPUBufferDescriptor/Usage

oops.

[Justin Fan]

Created attachment 361855 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 361855 [details]
Patch for landing

Clearing flags on attachment: 361855

Committed r241328: <https://trac.webkit.org/changeset/241328>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48020260>

[Darin Adler]

Comment on attachment 361855 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=361855&action=review

One small nit

> Source/WebCore/platform/graphics/gpu/GPUBufferDescriptor.h:35
>      unsigned long size;

This should be "unsigned", not "unsigned long". An "unsigned long" in IDL corresponds to "unsigned" in C++. Confusing, I know, and also "unsigned long" is *almost* the same thing as "unsigned".

> Source/WebCore/platform/graphics/gpu/GPUBufferUsage.h:34
> +using GPUBufferUsageFlags = unsigned long;

This should be "unsigned", not "unsigned long".

[Justin Fan]

Comment on attachment 361855 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=361855&action=review

>> Source/WebCore/platform/graphics/gpu/GPUBufferDescriptor.h:35
>>      unsigned long size;
> 
> This should be "unsigned", not "unsigned long". An "unsigned long" in IDL corresponds to "unsigned" in C++. Confusing, I know, and also "unsigned long" is *almost* the same thing as "unsigned".

I did not know that, thanks. It looks like I have a lot of instances to fix for this across the Web GPU code base, then. I've planned out a week to do all sorts of clean-up for Web GPU so I'll add this to that to-do list. https://bugs.webkit.org/show_bug.cgi?id=194618