Bug 194552 - [WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions
Summary: [WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-12 12:50 PST by Justin Fan
Modified: 2019-02-13 15:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (37.39 KB, patch)
2019-02-12 13:00 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (37.39 KB, patch)
2019-02-12 13:29 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (37.42 KB, patch)
2019-02-12 14:08 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch (37.34 KB, patch)
2019-02-12 14:16 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch for landing (38.12 KB, patch)
2019-02-12 15:41 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-02-12 12:50:55 PST 
[WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions
Comment 1 Justin Fan 2019-02-12 13:00:38 PST 
Created attachment 361825 [details]
Patch
Comment 2 Justin Fan 2019-02-12 13:29:22 PST 
Created attachment 361829 [details]
Patch
Comment 3 Justin Fan 2019-02-12 14:08:56 PST 
Created attachment 361838 [details]
Patch
Comment 4 Justin Fan 2019-02-12 14:16:36 PST 
Created attachment 361839 [details]
Patch
Comment 5 Dean Jackson 2019-02-12 14:16:47 PST 
Comment on attachment 361838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361838&action=review

r=me but make sure not to commit the conflicted Sources.txt

> Source/WebCore/Sources.txt:2774
> +<<<<<<< HEAD
>  JSGPUColor.cpp
> +=======
> +JSGPUBufferDescriptor.cpp
> +JSGPUBufferUsage.cpp
> +>>>>>>> 57c93d27a40... Removed WebGPUBufferDescriptor/Usage for GPUBufferDescriptor/Usage

oops.
Comment 6 Justin Fan 2019-02-12 15:41:10 PST 
Created attachment 361855 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-02-12 16:23:16 PST 
Comment on attachment 361855 [details]
Patch for landing

Clearing flags on attachment: 361855

Committed r241328: <https://trac.webkit.org/changeset/241328>
Comment 8 WebKit Commit Bot 2019-02-12 16:23:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-02-12 16:24:28 PST 
<rdar://problem/48020260>
Comment 10 Darin Adler 2019-02-12 19:02:29 PST 
Comment on attachment 361855 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=361855&action=review

One small nit

> Source/WebCore/platform/graphics/gpu/GPUBufferDescriptor.h:35
>      unsigned long size;

This should be "unsigned", not "unsigned long". An "unsigned long" in IDL corresponds to "unsigned" in C++. Confusing, I know, and also "unsigned long" is *almost* the same thing as "unsigned".

> Source/WebCore/platform/graphics/gpu/GPUBufferUsage.h:34
> +using GPUBufferUsageFlags = unsigned long;

This should be "unsigned", not "unsigned long".
Comment 11 Justin Fan 2019-02-13 15:38:28 PST 
Comment on attachment 361855 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=361855&action=review

>> Source/WebCore/platform/graphics/gpu/GPUBufferDescriptor.h:35
>>      unsigned long size;
> 
> This should be "unsigned", not "unsigned long". An "unsigned long" in IDL corresponds to "unsigned" in C++. Confusing, I know, and also "unsigned long" is *almost* the same thing as "unsigned".

I did not know that, thanks. It looks like I have a lot of instances to fix for this across the Web GPU code base, then. I've planned out a week to do all sorts of clean-up for Web GPU so I'll add this to that to-do list. https://bugs.webkit.org/show_bug.cgi?id=194618