Bug 194537 - [GStreamer] Simplify GObject class name check
Summary: [GStreamer] Simplify GObject class name check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-12 06:42 PST by Bastien Nocera
Modified: 2019-02-15 15:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2019-02-15 08:48 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bastien Nocera 2019-02-12 06:42:24 PST 
This line:
https://sources.debian.org/src/webkit2gtk/2.23.3-1/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp/#L1754
reads:
if (g_strcmp0(G_OBJECT_CLASS_NAME(G_OBJECT_GET_CLASS(G_OBJECT(element))), "GstDownloadBuffer"))

It could be simplified to:
if (g_strcmp0(G_OBJECT_TYPE_NAME(element)), "GstDownloadBuffer"))
Comment 1 Philippe Normand 2019-02-15 08:48:19 PST 
Created attachment 362117 [details]
Patch
Comment 2 WebKit Commit Bot 2019-02-15 09:26:22 PST 
Comment on attachment 362117 [details]
Patch

Clearing flags on attachment: 362117

Committed r241590: <https://trac.webkit.org/changeset/241590>
Comment 3 WebKit Commit Bot 2019-02-15 09:26:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-02-15 15:30:45 PST 
<rdar://problem/48126892>