Bug 194523 - REGRESSION: ( r240978-r240985 ) [ iOS Release ] Layout Test imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is crashing
Summary: REGRESSION: ( r240978-r240985 ) [ iOS Release ] Layout Test imported/w3c/web-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-11 17:00 PST by Truitt Savell
Modified: 2019-03-11 12:07 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.72 KB, patch)
2019-02-14 17:31 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.50 KB, patch)
2019-02-19 14:47 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2019-03-08 11:22 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-02-11 17:00:56 PST
The following layout test is failing on iOS Release

imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm

Probable cause:

Test began crashing constantly on iOS release. I was able to reproduce locally but there is a gap in usable builds between r240978-r240985. the test passes on 240978 and crashes on r240985. There is no stderr for the crash. The test is already a constant failure. 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fsend-redirect-post-upload.htm

Crash:
https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r241280%20(2553)/imported/w3c/web-platform-tests/xhr/send-redirect-post-upload-crash-log.txt
Comment 1 Alex Christensen 2019-02-11 17:33:39 PST
This is a CFNetwork bug.  This won't be fixed by an open source change.
Comment 2 Alexey Proskuryakov 2019-02-14 11:47:55 PST
> This is a CFNetwork bug.  This won't be fixed by an open source change.

Alex, are you saying that this is not a regression in fact, and the bisection was wrong?

Otherwise, we must have done something to start triggering this bug, so we should undo that something.
Comment 3 Alex Christensen 2019-02-14 16:23:52 PST
I'll look into whether this was caused by https://trac.webkit.org/changeset/240984/webkit
Comment 4 Alex Christensen 2019-02-14 17:31:49 PST
Created attachment 362085 [details]
Patch
Comment 5 Geoffrey Garen 2019-02-15 10:22:45 PST
Comment on attachment 362085 [details]
Patch

> FormCreationContext* formContext = static_cast<FormCreationContext*>(context);

If you use adoptRef here, you can avoid the manual delete below.

auto formContext = adoptRef(...);
...
callOnMainThread([formContext]) { };
Comment 6 Alex Christensen 2019-02-15 10:31:00 PST
FormCreationContext is not refcounted.  I could call the std::unique_ptr constructor, but that would be less symmetric than this new/delete use which mirrors another new/delete pair in this file.
Comment 7 Alex Christensen 2019-02-15 10:51:24 PST
http://trac.webkit.org/r241594
Comment 8 Radar WebKit Bug Importer 2019-02-15 10:52:34 PST
<rdar://problem/48116418>
Comment 9 Alex Christensen 2019-02-18 15:02:03 PST
See rdar://problem/28233746
Comment 10 Alex Christensen 2019-02-19 14:47:07 PST
Reopening to attach new patch.
Comment 11 Alex Christensen 2019-02-19 14:47:08 PST
Created attachment 362434 [details]
Patch
Comment 12 Alex Christensen 2019-02-20 15:46:45 PST
rdar://problem/48211292
Comment 13 Alex Christensen 2019-03-04 11:54:37 PST
http://trac.webkit.org/r242367
Comment 14 Shawn Roberts 2019-03-06 09:45:47 PST
Test is still crashing or is a flaky failure on Peace iOS simulator

Dashboard :

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fsend-redirect-post-upload.htm

Reproduced with:

run-webkit-tests imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm --iterations 20 -f --ios-simulator

Crash Log :

https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r242534%20(2989)/imported/w3c/web-platform-tests/xhr/send-redirect-post-upload-crash-log.txt

Process:               com.apple.WebKit.Networking.Development [21918]
Path:                  /Volumes/VOLUME/*/WebKit.framework/XPCServices/com.apple.WebKit.Networking.xpc/com.apple.WebKit.Networking.Development
Identifier:            com.apple.WebKit.Networking.Development
Version:               608+ (608.1.6+)
Code Type:             X86-64 (Native)
Parent Process:        launchd_sim [16059]
Responsible:           com.apple.WebKit.Networking.Development [21918]
User ID:               501

Date/Time:             2019-03-06 04:16:11.319 -0800
OS Version:            Mac OS X 10.13.6 (17G65)
Report Version:        12
Anonymous UUID:        08BAA9A8-3D60-DCF9-81D2-FF44C6DAE18D


Time Awake Since Boot: 650000 seconds

System Integrity Protection: disabled

Crashed Thread:        9  Dispatch queue: com.apple.CFNetwork.Connection

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000058
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [0]

VM Regions Near 0x58:
--> 
    __TEXT                 000000010b840000-000000010b841000 [    4K] r-x/rwx SM=COW  /Volumes/VOLUME/*/WebKit.framework/XPCServices/com.apple.WebKit.Networking.xpc/com.apple.WebKit.Networking.Development

Application Specific Information:
CoreSimulator 581.2 - Device: Managed 6 - Runtime: iOS 12.1 (16B91) - DeviceType: iPhone SE

Thread 0:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x000000010f6cf20a mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x000000010f6ce724 mach_msg + 60
2   com.apple.CoreFoundation      	0x000000010df071b4 __CFRunLoopServiceMachPort + 212
3   com.apple.CoreFoundation      	0x000000010df017e9 __CFRunLoopRun + 1689
Comment 15 Alex Christensen 2019-03-08 11:22:22 PST
Reopening to attach new patch.
Comment 16 Alex Christensen 2019-03-08 11:22:23 PST
Created attachment 364041 [details]
Patch
Comment 17 WebKit Commit Bot 2019-03-11 12:07:44 PDT
Comment on attachment 364041 [details]
Patch

Clearing flags on attachment: 364041

Committed r242723: <https://trac.webkit.org/changeset/242723>
Comment 18 WebKit Commit Bot 2019-03-11 12:07:46 PDT
All reviewed patches have been landed.  Closing bug.