Bug 194519 - [Cocoa] Web Automation: client callbacks are not called if delegate does not override
Summary: [Cocoa] Web Automation: client callbacks are not called if delegate does not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-11 15:45 PST by BJ Burg
Modified: 2019-02-11 17:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2019-02-11 15:49 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2019-02-11 15:45:57 PST 
For some platforms that can't resize, it's not expected that setWindowFrame has any effect. However, it and other completion handler-based methods need to always call the completion handler. For example, some of those methods are called when going in/out of fullscreen.
Comment 1 Radar WebKit Bug Importer 2019-02-11 15:46:28 PST 
<rdar://problem/47981961>
Comment 2 BJ Burg 2019-02-11 15:49:21 PST 
Created attachment 361723 [details]
Patch
Comment 3 Joseph Pecoraro 2019-02-11 15:50:26 PST 
Comment on attachment 361723 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-02-11 17:15:55 PST 
Comment on attachment 361723 [details]
Patch

Clearing flags on attachment: 361723

Committed r241285: <https://trac.webkit.org/changeset/241285>
Comment 5 WebKit Commit Bot 2019-02-11 17:15:57 PST 
All reviewed patches have been landed.  Closing bug.