RESOLVED FIXED 194511
Branch-Only: Use Async message infrastructure for storageAccess API 
https://bugs.webkit.org/show_bug.cgi?id=194511
Summary Branch-Only: Use Async message infrastructure for storageAccess API
Brent Fulgham
Reported 2019-02-11 13:12:07 PST
Back-port the async message handling implementation of the StorageAccess API methods. The generated Async message handling code does a better job of handling the bookkeeping and error handling of cross-process message passing, and gives us fewer opportunities to make errors leading to dropped messages or sending messages multiple times. Update the StorageAccess API calls to use autogenerated message handlers since this improves stability and correctness.
Attachments
Patch (9.93 KB, patch)
2019-02-11 13:19 PST, Brent Fulgham 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-02-11 13:13:00 PST
Note: This code was generated against the safari-607-branch, so likely will not apply to trunk (and therefore EWS).
Brent Fulgham
Comment 2 2019-02-11 13:17:17 PST
<rdar://problem/40966400>
Brent Fulgham
Comment 3 2019-02-11 13:19:46 PST
Created attachment 361706 [details] Patch
Alex Christensen
Comment 4 2019-02-11 15:54:33 PST
Comment on attachment 361706 [details] Patch r=me for the branch Are all these happening on the main thread?
Brent Fulgham
Comment 5 2019-02-11 17:04:49 PST
(In reply to Alex Christensen from comment #4) > Comment on attachment 361706 [details] > Patch > > r=me for the branch > Are all these happening on the main thread? Yes, although the code inside ResourceLoadStatistics dispatches to a background thread, before hopping back to main thread to respond.
Note You need to log in before you can comment on or make changes to this bug.