Bug 194495 - [GStreamer] GstMappedBuffer testsuite build fails
Summary: [GStreamer] GstMappedBuffer testsuite build fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on: 192977
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-11 02:46 PST by Philippe Normand
Modified: 2019-02-11 06:00 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2019-02-11 02:49 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-02-11 02:46:34 PST 
+++ This bug was initially created as a clone of Bug #192977 +++

[GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite

In file included from ../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:25:0,
                 from ../Source/WebCore/platform/SharedBuffer.h:52,
                 from ../Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:32:
../Source/WebCore/platform/graphics/gstreamer/GUniquePtrGStreamer.h:24:10: fatal error: gst/audio/audio.h: No such file or directory
 #include <gst/audio/audio.h>
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.

This happens only if I try to build within my gst-build environment, the fix is trivial. Attaching a patch...
Comment 1 Philippe Normand 2019-02-11 02:49:47 PST 
Created attachment 361669 [details]
Patch
Comment 2 WebKit Commit Bot 2019-02-11 04:14:55 PST 
Comment on attachment 361669 [details]
Patch

Clearing flags on attachment: 361669

Committed r241261: <https://trac.webkit.org/changeset/241261>
Comment 3 WebKit Commit Bot 2019-02-11 04:14:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Xabier Rodríguez Calvar 2019-02-11 06:00:27 PST 
Good, nice catch.