Bug 194487 – Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Adler]

Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)

[Darin Adler]

Created attachment 361652 [details]
Patch

[Darin Adler]

Created attachment 361654 [details]
Patch

[Darin Adler]

Created attachment 361658 [details]
Patch

[Darin Adler]

Created attachment 361889 [details]
Patch

[EWS Watchlist]

Comment on attachment 361889 [details]
Patch

Attachment 361889 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11132151

New failing tests:
http/tests/inspector/network/resource-initiatorNode.html

[EWS Watchlist]

Created attachment 361902 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Darin Adler]

These crashes in PixelBufferConformerCV::convert are ones that I saw on another patch of mine as well, and have nothing to do with this patch.

[Daniel Bates]

Comment on attachment 361889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361889&action=review

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:54
> -    String filename = String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s", resource, extension);
> +    String filename = makeString("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\", resource, '.', extension);

My eyes! Raw strings will save us. No change necessary.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:618
> +        if (parentName && parentName[0]) {

Nice!

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:631
> +    builder.appendNumber(element->x(), 6, KeepTrailingZeros);

No chance necessary. Not so nice in my eyes :/

[Darin Adler]

Comment on attachment 361889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361889&action=review

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:631
>> +    builder.appendNumber(element->x(), 6, KeepTrailingZeros);
> 
> No chance necessary. Not so nice in my eyes :/

The long term is that we want more people to use the default formatting for doubles rather than choosing the strange "6 digit precision with trailing zeros" format. We’ll come through later to simplify that.

[Darin Adler]

Committed r241587: <https://trac.webkit.org/changeset/241587>

[Radar WebKit Bug Importer]

<rdar://problem/48111181>