Bug 194483 - [LFC] FormattingContext::intrinsicWidthConstraints should compute and save the intrinsic widths consistently.
Summary: [LFC] FormattingContext::intrinsicWidthConstraints should compute and save th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-10 14:41 PST by zalan
Modified: 2019-02-11 08:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.59 KB, patch)
2019-02-10 15:17 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.93 KB, patch)
2019-02-10 21:32 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-10 14:41:27 PST 
and name it computeInstrinsicWidthConstraints
Comment 1 zalan 2019-02-10 15:17:31 PST 
Created attachment 361647 [details]
Patch
Comment 2 Darin Adler 2019-02-10 15:54:31 PST 
Comment on attachment 361647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361647&action=review

> Source/WebCore/ChangeLog:8
> +        Rename instrinsicWidthConstraints to computeInstrinsicWidthConstraints and it does not return the width values anymore.

Should also fix the spelling of the word "intrinsic", which is not spelled "instrinsic".
Comment 3 zalan 2019-02-10 21:32:07 PST 
Created attachment 361657 [details]
Patch
Comment 4 zalan 2019-02-11 08:19:43 PST 
Committed r241263: <https://trac.webkit.org/changeset/241263>
Comment 5 Radar WebKit Bug Importer 2019-02-11 08:20:42 PST 
<rdar://problem/47965287>