TestWebKitAPI.ProcessSwap.SessionStorage seems flaky. In https://ews-build.webkit-uat.org/#/builders/20/builds/819, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed. Same thing happened in https://ews-build.webkit-uat.org/#/builders/20/builds/829
Another one: https://ews-build.webkit-uat.org/#/builders/20/builds/880 (different test failure in re-run)
Can we prioritize this? I am working on EWS for API tests, and this flaky failure is creating problem.
(In reply to Aakash Jain from comment #2) > Can we prioritize this? > I am working on EWS for API tests, and this flaky failure is creating > problem. Ok, I think I should have some time to look into this today.
It looks like sometimes, when StorageManager::setItem() is called, findStorageArea(connection, storageMapID) returns null, so we fail to set the item.
It is very weird, I see the StorageManager::CreateSessionStorageMap() getting sent by the WebProcess, then the StorageManager::SetItem() getting sent by the WebProcess. However, when it fails, on the UIProcess side, I see StorageManager::setItem() getting called but not StorageManager::createSessionStorageMap(). I added an assertion on sending side and it did not hit so the sender side believes that it was successful sending both IPC messages. Both IPC messages are async so there is no way they could be processed out of order..
Created attachment 363141 [details] Patch
Created attachment 363147 [details] Patch
Comment on attachment 363147 [details] Patch Clearing flags on attachment: 363147 Committed r242182: <https://trac.webkit.org/changeset/242182>
All reviewed patches have been landed. Closing bug.
<rdar://problem/48458499>