Bug 194479 – [LFC][IFC] Add intrinsic width support for inline-block boxes

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 361625 [details]
Patch

[Antti Koivisto]

Comment on attachment 361625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361625&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:160
> +    auto usedValues = UsedHorizontalValues { { }, { }, { } };

Nice. Maybe give the fields = { } so you could just say UsedHorizontalValues { } here?

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:163
> +    layoutState().createFormattingContext(layoutBox)->instrinsicWidthConstraints();

It looks weird that this calls instrinsicWidthConstraints() but doesn't do anything with the return value. It would be nice if functions with side effect wouldn't sound like accessors.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 361625 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361625&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:160
> > +    auto usedValues = UsedHorizontalValues { { }, { }, { } };
> 
> Nice. Maybe give the fields = { } so you could just say UsedHorizontalValues
> { } here?
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:163
> > +    layoutState().createFormattingContext(layoutBox)->instrinsicWidthConstraints();
> 
> It looks weird that this calls instrinsicWidthConstraints() but doesn't do
> anything with the return value. It would be nice if functions with side
> effect wouldn't sound like accessors.
Yeah, I need to fix this eventually. They are either accessor functions and the caller saves the return value to the state or rename them to computeInstrinsicWidthConstraints(). I'll get back to it once I am done with floats.

[zalan]

Committed r241250: <https://trac.webkit.org/changeset/241250>

[Radar WebKit Bug Importer]

<rdar://problem/47949584>