RESOLVED FIXED Bug 194473
[LFC][IFC] Add intrinsic width support for basic inline containers 
https://bugs.webkit.org/show_bug.cgi?id=194473
Summary [LFC][IFC] Add intrinsic width support for basic inline containers
zalan
Reported 2019-02-09 08:26:38 PST
<span>foobar</span>
Attachments
Patch (23.30 KB, patch)
2019-02-09 08:48 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2019-02-09 08:48:17 PST
Created attachment 361607 [details] Patch
Antti Koivisto
Comment 2 2019-02-09 10:25:43 PST
Comment on attachment 361607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361607&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:138 > +void InlineFormattingContext::computeBorderAndPadding(const Box& layoutBox, UsedHorizontalValues usedValues) const > +{ > + auto& displayBox = layoutState().displayBoxForLayoutBox(layoutBox); > + displayBox.setBorder(Geometry::computedBorder(layoutBox)); > + displayBox.setPadding(Geometry::computedPadding(layoutBox, usedValues)); > +} This is in addition to FormattingContext::computeBorderAndPadding, right? Is there something inline specific here?
zalan
Comment 3 2019-02-09 12:11:13 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 361607 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361607&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:138 > > +void InlineFormattingContext::computeBorderAndPadding(const Box& layoutBox, UsedHorizontalValues usedValues) const > > +{ > > + auto& displayBox = layoutState().displayBoxForLayoutBox(layoutBox); > > + displayBox.setBorder(Geometry::computedBorder(layoutBox)); > > + displayBox.setPadding(Geometry::computedPadding(layoutBox, usedValues)); > > +} > > This is in addition to FormattingContext::computeBorderAndPadding, right? Is > there something inline specific here? Not at all. I am going to consolidate them once I am done with the intrinsic width patches.
WebKit Commit Bot
Comment 4 2019-02-09 12:37:08 PST
Comment on attachment 361607 [details] Patch Clearing flags on attachment: 361607 Committed r241243: <https://trac.webkit.org/changeset/241243>
WebKit Commit Bot
Comment 5 2019-02-09 12:37:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-02-09 12:42:27 PST
<rdar://problem/47943846>
Note You need to log in before you can comment on or make changes to this bug.