Bug 194472 - [GTK] Fix typo in the newly added API
Summary: [GTK] Fix typo in the newly added API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-09 02:27 PST by Alice Mikhaylenko
Modified: 2019-02-09 08:05 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2019-02-09 02:30 PST, Alice Mikhaylenko 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Mikhaylenko 2019-02-09 02:27:23 PST 
I shouldn't have used find and replace to change allow -> enabled in https://bugs.webkit.org/show_bug.cgi?id=193919
Comment 1 Alice Mikhaylenko 2019-02-09 02:30:25 PST 
Created attachment 361605 [details]
Patch
Comment 2 EWS Watchlist 2019-02-09 02:32:17 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2019-02-09 08:03:13 PST 
Comment on attachment 361605 [details]
Patch

We also need #if PLATFORM(GTK) guards in the WebKitSettings.cpp, since it's not available for WPE.
Comment 4 Michael Catanzaro 2019-02-09 08:04:13 PST 
Committed r241240: <https://trac.webkit.org/changeset/241240>
Comment 5 Michael Catanzaro 2019-02-09 08:05:03 PST 
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 361605 [details]
> Patch
> 
> We also need #if PLATFORM(GTK) guards in the WebKitSettings.cpp, since it's
> not available for WPE.

I see it's already in a larger group of guards. (I wonder why the font size setting is GTK-specific....)