Bug 194464 - GCHeapInspector: Show the retained sizes in more places
Summary: GCHeapInspector: Show the retained sizes in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 16:36 PST by Joseph Pecoraro
Modified: 2019-02-11 11:26 PST (History)
6 users (show)

See Also:

Attachments
[IMAGE] Retained Sizes (1.41 MB, image/png)
2019-02-08 16:36 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (4.05 KB, patch)
2019-02-08 16:37 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-02-08 16:36:34 PST 
Show the retained sizes in more places

Turns out the page already had node-size with a `display: none`. Add the retained size to a few other places and color them blue.
Comment 1 Joseph Pecoraro 2019-02-08 16:36:51 PST 
Created attachment 361560 [details]
[IMAGE] Retained Sizes
Comment 2 Joseph Pecoraro 2019-02-08 16:37:28 PST 
Created attachment 361562 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2019-02-11 11:25:56 PST 
Comment on attachment 361562 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 361562

Committed r241274: <https://trac.webkit.org/changeset/241274>
Comment 4 WebKit Commit Bot 2019-02-11 11:25:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-11 11:26:39 PST 
<rdar://problem/47971950>