Bug 194463 - [WK2][macOS] Avoid creating new CVDisplayLink objects for each WebProcess
Summary: [WK2][macOS] Avoid creating new CVDisplayLink objects for each WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 16:25 PST by Chris Dumez
Modified: 2019-02-08 20:38 PST (History)
6 users (show)

See Also:

Attachments
Patch (14.97 KB, patch)
2019-02-08 16:28 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.00 KB, patch)
2019-02-08 16:35 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.79 KB, patch)
2019-02-08 16:52 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.93 KB, patch)
2019-02-08 16:56 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-02-08 16:25:33 PST 
Avoid creating new CVDisplayLink objects for each WebProcess. We really only need one per display, creating such object is expensive and it is even worse in a PSON world where we swap process on navigation.
Comment 1 Chris Dumez 2019-02-08 16:28:33 PST 
Created attachment 361557 [details]
Patch
Comment 2 Chris Dumez 2019-02-08 16:35:43 PST 
Created attachment 361559 [details]
Patch
Comment 3 Chris Dumez 2019-02-08 16:52:01 PST 
Created attachment 361563 [details]
Patch
Comment 4 Chris Dumez 2019-02-08 16:56:58 PST 
Created attachment 361565 [details]
Patch
Comment 5 Tim Horton 2019-02-08 17:03:59 PST 
Nice!
Comment 6 WebKit Commit Bot 2019-02-08 20:37:03 PST 
Comment on attachment 361565 [details]
Patch

Clearing flags on attachment: 361565

Committed r241232: <https://trac.webkit.org/changeset/241232>
Comment 7 WebKit Commit Bot 2019-02-08 20:37:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-08 20:38:28 PST 
<rdar://problem/47938388>