Bug 194462 - Add more more test for clampTo<>()
Summary: Add more more test for clampTo<>()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 16:14 PST by Benjamin Poulain
Modified: 2019-02-09 16:47 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2019-02-08 16:23 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (3.00 KB, patch)
2019-02-08 20:13 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2019-02-08 16:14:46 PST 
Add more more test for clampTo<>()
Comment 1 Benjamin Poulain 2019-02-08 16:23:11 PST 
Created attachment 361555 [details]
Patch
Comment 2 Benjamin Poulain 2019-02-08 20:13:45 PST 
Created attachment 361589 [details]
Patch
Comment 3 Geoffrey Garen 2019-02-08 22:07:48 PST 
Comment on attachment 361589 [details]
Patch

r=me
Comment 4 Darin Adler 2019-02-09 09:48:34 PST 
Comment on attachment 361589 [details]
Patch

Great, that’s exactly what I had in mind. Could do the same for float.
Comment 5 Benjamin Poulain 2019-02-09 16:16:29 PST 
Comment on attachment 361589 [details]
Patch

Thanks for the reviews.

Before adding float I'd like to go back to the timer optimizations.
Comment 6 Darin Adler 2019-02-09 16:31:40 PST 
(In reply to Benjamin Poulain from comment #5)
> Before adding float I'd like to go back to the timer optimizations.

Yes, I agree, that’s way more valuable.

I think you’ve already spent enough time on this. A nice idea to come back later and do a tiny bit more minor tweaking on the tests, but not really important at all. I didn’t mean to keep you stuck on this.
Comment 7 WebKit Commit Bot 2019-02-09 16:42:01 PST 
Comment on attachment 361589 [details]
Patch

Clearing flags on attachment: 361589

Committed r241247: <https://trac.webkit.org/changeset/241247>
Comment 8 WebKit Commit Bot 2019-02-09 16:42:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-02-09 16:47:08 PST 
<rdar://problem/47945009>