Bug 194461 - [ews-build] Ensure that every builder in config.json has short name
Summary: [ews-build] Ensure that every builder in config.json has short name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 15:51 PST by Aakash Jain
Modified: 2019-02-08 16:32 PST (History)
4 users (show)

See Also:

Attachments
Proposed patch (7.98 KB, patch)
2019-02-08 15:53 PST, Aakash Jain 		lforschler: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-08 15:51:32 PST 
We should ensure that every builder in config.json has short name. loadConfig should fail to load the config if a builder doesn't have shortname defined. Unit-tests should also fail in such case. This would make it almost impossible for someone to "forget" adding shortname while adding a new builder.
Comment 1 Aakash Jain 2019-02-08 15:53:08 PST 
Created attachment 361548 [details]
Proposed patch
Comment 2 Lucas Forschler 2019-02-08 16:05:14 PST 
Comment on attachment 361548 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361548&action=review

> Tools/BuildSlaveSupport/ews-build/loadConfig.py:105
> +        raise Exception('Builder "{}" does not have short name defined. This name is needed for EWS status-bubbles.'.format(builder.get('name')))

I don't think status bubbles should be hyphenated.

> Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py:113
> +        self.assertEqual(context.exception.args, ('Builder "mac-wk2(test)" does not have short name defined. This name is needed for EWS status-bubbles.',))

ditto
Comment 3 Aakash Jain 2019-02-08 16:31:32 PST 
Committed r241221: <https://trac.webkit.org/changeset/241221>
Comment 4 Radar WebKit Bug Importer 2019-02-08 16:32:50 PST 
<rdar://problem/47934404>