RESOLVED FIXED 194461
[ews-build] Ensure that every builder in config.json has short name 
https://bugs.webkit.org/show_bug.cgi?id=194461
Summary [ews-build] Ensure that every builder in config.json has short name
Aakash Jain
Reported 2019-02-08 15:51:32 PST
We should ensure that every builder in config.json has short name. loadConfig should fail to load the config if a builder doesn't have shortname defined. Unit-tests should also fail in such case. This would make it almost impossible for someone to "forget" adding shortname while adding a new builder.
Attachments
Proposed patch (7.98 KB, patch)
2019-02-08 15:53 PST, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-02-08 15:53:08 PST
Created attachment 361548 [details] Proposed patch
Lucas Forschler
Comment 2 2019-02-08 16:05:14 PST
Comment on attachment 361548 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=361548&action=review > Tools/BuildSlaveSupport/ews-build/loadConfig.py:105 > + raise Exception('Builder "{}" does not have short name defined. This name is needed for EWS status-bubbles.'.format(builder.get('name'))) I don't think status bubbles should be hyphenated. > Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py:113 > + self.assertEqual(context.exception.args, ('Builder "mac-wk2(test)" does not have short name defined. This name is needed for EWS status-bubbles.',)) ditto
Aakash Jain
Comment 3 2019-02-08 16:31:32 PST
Committed r241221: <https://trac.webkit.org/changeset/241221>
Radar WebKit Bug Importer
Comment 4 2019-02-08 16:32:50 PST
<rdar://problem/47934404>
Note You need to log in before you can comment on or make changes to this bug.