Bug 194459 – Web Inspector: Debugger Popover should work with value in template string `${identifier}`

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Debugger Popover should work with value in template string `${identifier}`

Steps to Reproduce:
1. Pause on a line like:
    let foo = `${window}`;
2. Hover over "window"
  => Expected debugger popover, but did not get one.

[Radar WebKit Bug Importer]

<rdar://problem/47932564>

[Joseph Pecoraro]

Created attachment 361550 [details]
[PATCH] Proposed Fix

Tested with:

<script>
setTimeout(() => {
    document.body.onclick = () => {
        let before = "test";
        let array = [1, 2, 3];
        console.log(`before ${array} after ${array.length}`);
        debugger;
    };
});
</script>

• Was able to hover and get popovers inside of these:
${array} and ${array.length}

• Did not get a popover when hovering the "before" in `before ...`.

[Devin Rousso]

Comment on attachment 361550 [details]
[PATCH] Proposed Fix

rs=me, I like it!

[WebKit Commit Bot]

Comment on attachment 361550 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 361550

Committed r241225: <https://trac.webkit.org/changeset/241225>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.