Bug 194459 - Web Inspector: Debugger Popover should work with value in template string `${identifier}`
Summary: Web Inspector: Debugger Popover should work with value in template string `${...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 15:38 PST by Joseph Pecoraro
Modified: 2019-02-08 17:30 PST (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.38 KB, patch)
2019-02-08 15:56 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-02-08 15:38:31 PST
Debugger Popover should work with value in template string `${identifier}`

Steps to Reproduce:
1. Pause on a line like:
    let foo = `${window}`;
2. Hover over "window"
  => Expected debugger popover, but did not get one.
Comment 1 Radar WebKit Bug Importer 2019-02-08 15:39:46 PST
<rdar://problem/47932564>
Comment 2 Joseph Pecoraro 2019-02-08 15:56:31 PST
Created attachment 361550 [details]
[PATCH] Proposed Fix

Tested with:

<script>
setTimeout(() => {
    document.body.onclick = () => {
        let before = "test";
        let array = [1, 2, 3];
        console.log(`before ${array} after ${array.length}`);
        debugger;
    };
});
</script>

• Was able to hover and get popovers inside of these:
${array} and ${array.length}

• Did not get a popover when hovering the "before" in `before ...`.
Comment 3 Devin Rousso 2019-02-08 17:01:53 PST
Comment on attachment 361550 [details]
[PATCH] Proposed Fix

rs=me, I like it!
Comment 4 WebKit Commit Bot 2019-02-08 17:30:22 PST
Comment on attachment 361550 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 361550

Committed r241225: <https://trac.webkit.org/changeset/241225>
Comment 5 WebKit Commit Bot 2019-02-08 17:30:24 PST
All reviewed patches have been landed.  Closing bug.