Bug 194458 – [Web GPU] DepthStencilAttachment implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[Web GPU] DepthStencilAttachment implementation

[Radar WebKit Bug Importer]

<rdar://problem/47932446>

[Justin Fan]

Created attachment 361552 [details]
Patch

[Justin Fan]

Comment on attachment 361552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361552&action=review

> Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.cpp:36
> +Optional<GPURenderPassDescriptor> WebGPURenderPassDescriptor::validateAndConvertToGPUVersion() const

I'm moving this conversion logic here to un-clutter the create() function; if this looks good, I can do this to the similar create() functions in GPUDevice to neaten it up anywhere the descriptor conversion isn't trivial.

> Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.h:42
> +struct WebGPURenderPassColorAttachmentDescriptor {

I'd like to do this for more IDL structs eventually (move structs that aren't used anywhere else into their parent structs' headers). It will greatly reduce the number of files floating around in our project. Let me know what you think.

[Justin Fan]

Created attachment 361558 [details]
Patch

[Dean Jackson]

Comment on attachment 361558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361558&action=review

> Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.h:43
> +struct WebGPURenderPassColorAttachmentDescriptor {
> +    RefPtr<WebGPUTextureView> attachment;

Could we use GPURenderPassColorAttachmentDescriptor for the rest of this struct?

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:50
> +    }

Add ASSERT_NOT_REACHED, even though the compiler should error if this ever happens.

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:55
> +    return MTLStoreActionStore;

Add an ASSERT

[Justin Fan]

Created attachment 361746 [details]
Patch

[EWS Watchlist]

Attachment 361746 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.cpp:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 361746 [details]
Patch

Attachment 361746 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11116915

New failing tests:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

[EWS Watchlist]

Created attachment 361761 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Justin Fan]

Created attachment 361814 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 361814 [details]
Patch for landing

Clearing flags on attachment: 361814

Committed r241310: <https://trac.webkit.org/changeset/241310>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.