Bug 194452 - Use maxSingleCharacterString in comparisons instead of literal constants.
Summary: Use maxSingleCharacterString in comparisons instead of literal constants.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 14:41 PST by Mark Lam
Modified: 2019-02-08 15:09 PST (History)
8 users (show)

See Also:

Attachments
proposed patch. (5.17 KB, patch)
2019-02-08 14:44 PST, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-02-08 14:41:58 PST 
This way, if we ever change maxSingleCharacterString, it won't break all this code that relies on it being 0xff implicitly.
Comment 1 Mark Lam 2019-02-08 14:44:39 PST 
Created attachment 361536 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2019-02-08 14:47:03 PST 
Comment on attachment 361536 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2019-02-08 15:07:22 PST 
Thanks for the review.  Landed in r241214: <http://trac.webkit.org/r241214>.
Comment 4 Radar WebKit Bug Importer 2019-02-08 15:09:29 PST 
<rdar://problem/47931478>