Bug 194445 - Web Inspector: Add Debug setting to show Internal Object Classes in Heap Snapshot
Summary: Web Inspector: Add Debug setting to show Internal Object Classes in Heap Snap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-08 12:22 PST by Joseph Pecoraro
Modified: 2019-02-08 15:52 PST (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.81 KB, patch)
2019-02-08 12:23 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[IMAGE] Instances list with Internal Object Classes (881.36 KB, image/png)
2019-02-08 15:27 PST, Joseph Pecoraro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-02-08 12:22:47 PST
Add Debug setting to show Internal Object Classes in Heap Snapshot

This will make it easier for WebKit Developers to use the Heap Snapshot graph to investigate memory of internal objects.

Note: To enable the Debug Settings pane:
1. Run a local build of Safari
2. Open Web Inspector
3. Use ⇧⌥⌘D keyboard shortcut to enable Debug UI
4. Go to the Settings tab in Web Inspector
  => There will now be a Debug pane
Comment 1 Joseph Pecoraro 2019-02-08 12:23:10 PST
Created attachment 361523 [details]
[PATCH] Proposed Fix
Comment 2 Nikita Vasilyev 2019-02-08 12:31:05 PST
Comment on attachment 361523 [details]
[PATCH] Proposed Fix

Would it make sense to make a setting to show internal events & objects for the entire Timeline tab?
Comment 3 Devin Rousso 2019-02-08 13:23:35 PST
Comment on attachment 361523 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361523&action=review

rs=me

Can you attach a screenshot, just so we can see what types of things would appear?  Considering that we've never shown internal objects (unless they were also used non-internally), it may be useful to know what they look like for future reference.

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:332
>  

Aside: should there also be a separator between "Debugging:" and "Uncaught Exception Reporter:"?
Comment 4 Joseph Pecoraro 2019-02-08 15:26:38 PST
(In reply to Devin Rousso from comment #3)
> Comment on attachment 361523 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361523&action=review
> 
> rs=me
> 
> Can you attach a screenshot, just so we can see what types of things would
> appear?  Considering that we've never shown internal objects (unless they
> were also used non-internally), it may be useful to know what they look like
> for future reference.

Sure. We show internal objects when you expand an object, but we didn't show internal object classes at the top level. Now we do. So nothing new (Structure, *Executable, InferredValue, *GetterSetter, etc)
Comment 5 Joseph Pecoraro 2019-02-08 15:27:03 PST
Created attachment 361541 [details]
[IMAGE] Instances list with Internal Object Classes
Comment 6 WebKit Commit Bot 2019-02-08 15:51:57 PST
Comment on attachment 361523 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 361523

Committed r241216: <https://trac.webkit.org/changeset/241216>
Comment 7 WebKit Commit Bot 2019-02-08 15:51:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-08 15:52:30 PST
<rdar://problem/47932949>