Bug 194445 – Web Inspector: Add Debug setting to show Internal Object Classes in Heap Snapshot

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Add Debug setting to show Internal Object Classes in Heap Snapshot

This will make it easier for WebKit Developers to use the Heap Snapshot graph to investigate memory of internal objects.

Note: To enable the Debug Settings pane:
1. Run a local build of Safari
2. Open Web Inspector
3. Use ⇧⌥⌘D keyboard shortcut to enable Debug UI
4. Go to the Settings tab in Web Inspector
  => There will now be a Debug pane

[Joseph Pecoraro]

Created attachment 361523 [details]
[PATCH] Proposed Fix

[Nikita Vasilyev]

Comment on attachment 361523 [details]
[PATCH] Proposed Fix

Would it make sense to make a setting to show internal events & objects for the entire Timeline tab?

[Devin Rousso]

Comment on attachment 361523 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361523&action=review

rs=me

Can you attach a screenshot, just so we can see what types of things would appear?  Considering that we've never shown internal objects (unless they were also used non-internally), it may be useful to know what they look like for future reference.

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:332
>  

Aside: should there also be a separator between "Debugging:" and "Uncaught Exception Reporter:"?

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 361523 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361523&action=review
> 
> rs=me
> 
> Can you attach a screenshot, just so we can see what types of things would
> appear?  Considering that we've never shown internal objects (unless they
> were also used non-internally), it may be useful to know what they look like
> for future reference.

Sure. We show internal objects when you expand an object, but we didn't show internal object classes at the top level. Now we do. So nothing new (Structure, *Executable, InferredValue, *GetterSetter, etc)

[Joseph Pecoraro]

Created attachment 361541 [details]
[IMAGE] Instances list with Internal Object Classes

[WebKit Commit Bot]

Comment on attachment 361523 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 361523

Committed r241216: <https://trac.webkit.org/changeset/241216>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47932949>